Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI/TEST: Separate build, test and publish stages #5

Merged
merged 5 commits into from
Aug 25, 2022
Merged

CI/TEST: Separate build, test and publish stages #5

merged 5 commits into from
Aug 25, 2022

Conversation

effigies
Copy link

@TheChymera For the sake of maintainable CI, I separated out the build, test and publish stages. Will make some comments to highlight the important bits.

effigies
effigies commented Aug 25, 2022
View reviewed changes
.github/workflows/schemacode_ci.yml Show resolved Hide resolved
.github/workflows/schemacode_ci.yml Show resolved Hide resolved
.github/workflows/schemacode_ci.yml Show resolved Hide resolved
.github/workflows/schemacode_ci.yml Show resolved Hide resolved
scripts/test_tag Outdated Show resolved Hide resolved
scripts/test_tag Show resolved Hide resolved
scripts/test_tag Show resolved Hide resolved
tools/schemacode/bidsschematools/tests/conftest.py Show resolved Hide resolved
tools/schemacode/bidsschematools/tests/test_make_testdata.py Show resolved Hide resolved
TheChymera
TheChymera requested changes Aug 25, 2022
View reviewed changes
Copy link
Owner

@TheChymera TheChymera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :) Most comments are just questions, but I really think (1) we'd be better off sticking with os.path unless there's something I'm missing; and (2) epoch is nicer, maybe you're more relaxed but I've certainly committed more than once a minute.

scripts/test_tag Show resolved Hide resolved
scripts/test_tag Show resolved Hide resolved
tools/schemacode/bidsschematools/tests/conftest.py Show resolved Hide resolved
tools/schemacode/bidsschematools/tests/test_make_testdata.py Show resolved Hide resolved
tools/schemacode/bidsschematools/tests/test_make_testdata.py Show resolved Hide resolved
.github/workflows/schemacode_ci.yml Show resolved Hide resolved
.github/workflows/schemacode_ci.yml Show resolved Hide resolved
.github/workflows/schemacode_ci.yml Show resolved Hide resolved
.github/workflows/schemacode_ci.yml Show resolved Hide resolved
scripts/test_tag Outdated Show resolved Hide resolved
@effigies
MNT: Update test_tag
b9e526f 
Run from anywhere, use meaningful commit/tag messages, do not push
automatically
@TheChymera TheChymera merged commit c763bb0 into TheChymera:autodata2 Aug 25, 2022
@effigies effigies deleted the autodata2 branch August 25, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheChymera TheChymera TheChymera requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@effigies @TheChymera