Update to Shopify CLI version v3.57.0 #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreyguenther
changed the title
jeffreyguenther
force-pushed
the
jeff/update-to-latest-shopify-cli
branch
12 times, most recently
from
1c9a3ee to
42b99cb
Compare
jeffreyguenther
changed the title
We want to use the latest Shopify packages. Shopify has upgrade the CLI to use oclif 3.15.1. As a result, I update this project to use it.
Some imports have changed so we need to update the project.
We can't assume file separators. joinPath handles this for us.
jeffreyguenther
force-pushed
the
jeff/update-to-latest-shopify-cli
branch
from
42b99cb to
a09ca6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I update Shopkeeper to use v3.57.0 of Shopify's CLI packages. Bugs have been fixed and improvements made, so let's incorporate them. Updating is important because when a project uses Shopkeeper it comes with a pinned version of the Shopify CLI. The project gets whichever version of the Shopify CLI that we're built on.
I'd like to use a more permissive version like all 3.x, but this has caused issues in the past as Shopify has made changes we're not compatible with. Thus, we stay pinned.
Ideally, we would release a new patch release for each Shopify patch release. One day, one day. Maybe if this thing gets popular.
In this PR, we also update to oclif v3.15.1 as this is what Shopify's CLI is pinned to. When they update, we update.