Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Closes #229.
The
bevy run web
command cannot just wrapcargo run
, as we don't want to run a native application, but run the code in the user's browser.Hence, we have to manually build with
cargo build
instead.This causes quite a lot of code (also including calling
wasm-bindgen
) to be duplicated betweenbevy build web
andbevy run web
.To ensure consistency and aid development, the code should be shared where possible.
This will enable us to build more complex features like #226.
Solution
bevy build web
into dedicated function.bevy build web
logic inbevy run web
as well.The functionality should be equivalent.
In the future, we might refine how exactly the shared build function is called.
For example, I assume that we will pass the binary targets we want to build from the outside instead of determining it in the function itself, that will enable us to implement changes like #200 and #230.