Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install the exact wasm-bindgen-cli version matching the wasm-bindgen version #208

Merged

Conversation

DaAlbrecht
Copy link
Contributor

Closes #202

@DaAlbrecht
Copy link
Contributor Author

DaAlbrecht commented Dec 29, 2024

Changing

let metadata = cargo::metadata::metadata_with_args(["--no-deps"])?;

to just

let metadata = cargo::metadata:()?;

and pass a reference to both bevy_cli::run::select_run_binary and ensure_web_setup does not work without changing the logic used to narrow down which binary to run if no was specified by the user

src/build/mod.rs Show resolved Hide resolved
src/external_cli/cargo/install.rs Outdated Show resolved Hide resolved
version otherwise prompt to install and replace
@DaAlbrecht
Copy link
Contributor Author

❯ wasm-bindgen --version
wasm-bindgen 0.2.80
❯ rustup target remove wasm32-unknown-unknown
❯ ../bevy_cli/target/debug/bevy run  web
Compilation target `wasm32-unknown-unknown` is missing, should I install it for you? yes
`wasm-bindgen:0.2.80` is installed, but version `0.2.99` is required. Install and replace? [y/n]
❯ wasm-bindgen --version
wasm-bindgen 0.2.99

Copy link
Collaborator

@TimJentzsch TimJentzsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
Just have two nits, but this can be merged when you think it's ready!

src/external_cli/wasm_bindgen.rs Outdated Show resolved Hide resolved
src/external_cli/cargo/install.rs Outdated Show resolved Hide resolved
@TimJentzsch TimJentzsch merged commit d6034dd into TheBevyFlock:main Dec 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure correct wasm-bindgen version
3 participants