-
-
Notifications
You must be signed in to change notification settings - Fork 44.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doctests for trapezoidal_rule.py #11491
base: master
Are you sure you want to change the base?
Add doctests for trapezoidal_rule.py #11491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your improvements! I left a few comments on some minor issues left over from the original code.
while x < (b - h): | ||
yield x | ||
x = x + h | ||
def make_points(a: float, b: float, h: float) -> Iterator[float]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we rename these variables for clarity? Rather than single-letter variable names, we could have something like lower_bound
, upper_bound
, and step_size
.
h = (boundary[1] - boundary[0]) / steps | ||
a = boundary[0] | ||
b = boundary[1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as my other comment: let's rename these variables to be more descriptive.
y = 0.0 | ||
y += (h / 2.0) * f(a) | ||
for i in x_i: | ||
# print(i) | ||
y += h * f(i) | ||
y += (h / 2.0) * f(b) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick: we can change 0.0
and 2.0
to just 0
and 2
. Python will appropriately cast values to float anyway, so I don't see a need to specify the decimal points.
Describe your change:
Contributes to #9943
Checklist: