Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Gaussian elimination pivoting #11393

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fix Gaussian elimination pivoting #11393

wants to merge 9 commits into from

Conversation

MaximSmolskiy
Copy link
Contributor

Describe your change:

Fix Gaussian elimination pivoting and warning:

linear_algebra/src/gaussian_elimination_pivoting/gaussian_elimination_pivoting.py::linear_algebra.src.gaussian_elimination_pivoting.gaussian_elimination_pivoting.solve_linear_system
  /home/runner/work/Python/Python/linear_algebra/src/gaussian_elimination_pivoting/gaussian_elimination_pivoting.py:55: RuntimeWarning: invalid value encountered in scalar divide
    ab[i, column_num - 1]

on build Run tests stage

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Aug 25, 2024
@MaximSmolskiy
Copy link
Contributor Author

@tianyizheng02 please review

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Aug 25, 2024
tianyizheng02
tianyizheng02 requested changes Aug 25, 2024
View reviewed changes
linear_algebra/src/gaussian_elimination_pivoting.py

# Upper triangular matrix
if ab[column_num, column_num] == 0.0:
raise ValueError("Matrix is not correct")
Copy link
Contributor

@tianyizheng02 tianyizheng02 Aug 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have the error say "Matrix is singular" instead? "Not correct" is very vague. (This will need to be updated in the function docstring as well.)

linear_algebra/src/gaussian_elimination_pivoting.py
/ ab[column_num - 1, column_num - 1]
* ab[column_num - 1, :]
)
assert num_of_rows == num_of_columns
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of an assert, let's just have the function raise a ValueError instead.

linear_algebra/src/gaussian_elimination_pivoting.py
pass

# Upper triangular matrix
if ab[column_num, column_num] == 0.0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a tolerance for this comparison? That is, is there a risk that floating-point errors can cause this check to incorrectly fail?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MaximSmolskiy @tianyizheng02