-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add check_format.yml
#217
chore: add check_format.yml
#217
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #217 +/- ##
=======================================
Coverage 97.60% 97.60%
=======================================
Files 142 142
Lines 1796 1796
=======================================
Hits 1753 1753
Misses 43 43 ☔ View full report in Codecov by Sentry. |
d6e4d84
to
47b242f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i forgot about this but thanks!
Resolving conflicts, when formatting changes, can be painful. @uncomfyhalomacro could you please merge this PR? |
i dont have merge rights in some circumstances in this repository tbh. @Panquesito7 has the power here to do so |
a9504c9
to
94a94a4
Compare
89024c6
to
be89b24
Compare
be89b24
to
e606f97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that, it looks good. Thanks! 🚀
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Thanks! 🚀
I have noticed that formatting of some of the files is a bit off (cf. 7c18e42). This PR formats some of the files and adds a workflow checking the formatting it the future.