Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add check_format.yml #217

Merged

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Oct 30, 2023

I have noticed that formatting of some of the files is a bit off (cf. 7c18e42). This PR formats some of the files and adds a workflow checking the formatting it the future.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6046d53) 97.60% compared to head (1e3b029) 97.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   97.60%   97.60%           
=======================================
  Files         142      142           
  Lines        1796     1796           
=======================================
  Hits         1753     1753           
  Misses         43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 force-pushed the format_code_and_add_format_check branch 5 times, most recently from d6e4d84 to 47b242f Compare October 30, 2023 19:37
@vil02 vil02 marked this pull request as ready for review October 30, 2023 19:43
Copy link
Collaborator

@uncomfyhalomacro uncomfyhalomacro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i forgot about this but thanks!

@vil02
Copy link
Member Author

vil02 commented Oct 31, 2023

Resolving conflicts, when formatting changes, can be painful. @uncomfyhalomacro could you please merge this PR?

@uncomfyhalomacro
Copy link
Collaborator

Resolving conflicts, when formatting changes, can be painful. @uncomfyhalomacro could you please merge this PR?

i dont have merge rights in some circumstances in this repository tbh. @Panquesito7 has the power here to do so

@vil02 vil02 force-pushed the format_code_and_add_format_check branch from a9504c9 to 94a94a4 Compare November 13, 2023 17:13
@vil02 vil02 force-pushed the format_code_and_add_format_check branch 2 times, most recently from 89024c6 to be89b24 Compare January 6, 2024 14:02
@vil02 vil02 force-pushed the format_code_and_add_format_check branch from be89b24 to e606f97 Compare January 8, 2024 08:09
@Panquesito7 Panquesito7 added the enhancement New feature or request label Jan 15, 2024
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, it looks good. Thanks! 🚀

vil02 and others added 2 commits January 15, 2024 21:55
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
@vil02 vil02 requested a review from Panquesito7 January 15, 2024 20:58
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks! 🚀

@Panquesito7 Panquesito7 merged commit 384424b into TheAlgorithms:main Jan 15, 2024
14 checks passed
@vil02 vil02 deleted the format_code_and_add_format_check branch January 15, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants