-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test cases project euler #1575
base: master
Are you sure you want to change the base?
Test cases project euler #1575
Conversation
…hrown error in case of invalid input
@appgurueu @raklaptudirm I have added the test cases for all the existing Already created existing PRs for the Kindly verify and merge the PRs, if looks good. |
…ath98/Javascript into test-cases-project-euler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pr seems to have lots of unrelated changes which should be removed.
import { latticePath } from '../Problem015.js' | ||
|
||
describe('Lattice Paths', () => { | ||
test('if grid size is 2', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such repetitive tests should use test.each
/ it.each
to reduce the boilerplate.
@appgurueu Hi I want to contribute to make the last request changes is this PR available ? |
@mohmmadAyesh I think you'd have to ask @pomkarnath98 that. |
@pomkarnath98 is this pull request still open can i contribute to continue suggested changes? |
Hey, sorry for the late reply.
Please feel free to contribute to the PR 👍
…------------------------
Regards,
Omkarnath Parida
On Wed, Mar 27, 2024 at 2:39 AM mohmmad ayesh ***@***.***> wrote:
@pomkarnath98 <https://github.com/pomkarnath98> is this pull request
still open can i contribute to continue suggested changes?
—
Reply to this email directly, view it on GitHub
<#1575 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKEJWPJSVFIBE265TNUDU6TY2HIZNAVCNFSM6AAAAAA6N2GBEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRRGQ3TSNZXGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Describe your change:
Checklist:
Example:
UserProfile.js
is allowed butuserprofile.js
,Userprofile.js
,user-Profile.js
,userProfile.js
are notFixes: #{$ISSUE_NO}
.