-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
algorithm: find the middle of linked-list #1096
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the form we expect algorithms to be in. Please:
- Add comments;
- Make this a re-usable and exported function;
- Add tests
Hello @appgurueu, I hope the algorithm is now as expected:
Please review and suggest changes, if any. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no need for a class here; this should be a single function or a method of a linked list class (if there is a suitable one).
Hey @appgurueu, Adding a method in the existing LinkedList class made more sense. |
know more
Describe your change:
Checklist:
Example:
UserProfile.js
is allowed butuserprofile.js
,Userprofile.js
,user-Profile.js
,userProfile.js
are not