Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: countSubstrings function implementation #1091

Merged
merged 3 commits into from
Sep 7, 2022
Merged

add: countSubstrings function implementation #1091

merged 3 commits into from
Sep 7, 2022

Conversation

ajinkyac03
Copy link
Contributor

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not

Fixes #1090

appgurueu
appgurueu reviewed Sep 6, 2022
View reviewed changes
String/CountSubstrings.js Outdated Show resolved Hide resolved
appgurueu
appgurueu reviewed Sep 6, 2022
View reviewed changes
String/CountSubstrings.js Outdated Show resolved Hide resolved
appgurueu
appgurueu reviewed Sep 6, 2022
View reviewed changes
String/CountSubstrings.js Outdated Show resolved Hide resolved
appgurueu
appgurueu reviewed Sep 6, 2022
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about overlapping substrings? I might expect countSubstrings("aaa", "aa") to be 2. Currently this is undocumented & untested behavior.

appgurueu
appgurueu approved these changes Sep 6, 2022
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Runtime is O(n²) due to the naive implementation.

@appgurueu appgurueu added the algorithm Adds or improves an algorithm label Sep 6, 2022
@raklaptudirm raklaptudirm changed the title Added countSubstrings function implementation. add: countSubstrings function implementation. Sep 7, 2022
@raklaptudirm raklaptudirm changed the title add: countSubstrings function implementation. add: countSubstrings function implementation Sep 7, 2022
@raklaptudirm raklaptudirm merged commit 6c718c0 into TheAlgorithms:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

@appgurueu appgurueu appgurueu approved these changes

Assignees
No one assigned
Labels
algorithm Adds or improves an algorithm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Count occurrences of substring in a string function implementation not there
3 participants
@ajinkyac03 @appgurueu @raklaptudirm