sleep sort #5285
Open
sleep sort #5285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5285 +/- ##
============================================
+ Coverage 40.67% 40.74% +0.06%
- Complexity 2502 2509 +7
============================================
Files 519 520 +1
Lines 15447 15473 +26
Branches 2949 2953 +4
============================================
+ Hits 6283 6304 +21
- Misses 8869 8874 +5
Partials 295 295 ☔ View full report in Codecov by Sentry. |
aishuarya
force-pushed
the
feature/sleepSort
branch
8 times, most recently
from
5e02a8b
to
6e789ad
Compare
aishuarya
force-pushed
the
feature/sleepSort
branch
from
6e789ad
to
47f0a86
Compare
aishuarya
requested review from
yanglbme,
vil02 and
BamaCharanChhandogi
as code owners
vil02
requested changes
Jul 12, 2024
| for (int numbers : array) { | ||
| Thread thread = new Thread(() -> { | ||
| try { | ||
| Thread.sleep(numbers); // Sleep for 'num' milliseconds |
There was a problem hiding this comment.
Do you think it is a good idea to throw IllegalArgumentException, when any of the entries is negative?
aishuarya
force-pushed
the
feature/sleepSort
branch
from
79e82d2
to
9091ad8
Compare
aishuarya
force-pushed
the
feature/sleepSort
branch
from
9091ad8
to
bf2110c
Compare
|
@vil02 Addressed you comments ! Thanks . |
vil02
requested changes
Jul 13, 2024
Comment on lines
+37
to
+39
| if (number < 0) { | ||
| throw new IllegalArgumentException("All numbers must be non-negative. Found: " + number); | ||
| } |
There was a problem hiding this comment.
This should happen, before starting any of the new threads.
| List<Integer> sortedList = Collections.synchronizedList(new ArrayList<>()); | ||
| List<Thread> threads = new ArrayList<>(); | ||
|
|
||
| for (int number : array) { |
There was a problem hiding this comment.
Suggested change
| for (int number : array) { | |
| for (final int number : array) { |
|
@vil02 Addressed you comments . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-format -i --style=file path/to/your/file.java