Implement Smooth Sort #5236

JAPNITSINGH · 2024-06-18T09:37:25Z

I have read CONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized it.
All filenames are in PascalCase.
All functions and variable names follow Java naming conventions.
All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
All new code is formatted with clang-format -i --style=file path/to/your/file.java

next step is to improve it to leonardo sort

…eckstyle faults

JAPNITSINGH · 2024-06-18T10:21:23Z

Additionaly done the following to fix pervious issues:

I have run mvn pmd:check to ensure there are no pmd errors
I have run mvn checkstyle:checkstyle to ensure correct style is followed

src/main/java/com/thealgorithms/sorts/SmoothSort.java

vil02 · 2024-06-18T15:16:48Z

src/test/java/com/thealgorithms/sorts/SmoothSortTest.java

If the answer to the above questions is yes, then if should be enough to derive the SmoothSortTest from SortingAlgorithmTest.

I believe it is possible, I just have to use generic T[] in place of Integer[] modify the code a little bit and use .compareTo() and it should be good. I shall work on it and update this PR. I'll comment here once changes are ready.

I have updated the code, haven't pushed it yet. The smooth sort algorithm I implemented seems to be failing for most arrays of size greater than 700. I guess the problem is with how I am calculating the left child of a node. I am having a look into it. I shall provide an update here once I am done with the fix

I have updated to code, derived the class from SortAlgorithm, removed unnecessary return statements , renamed variables to make the code more understandable.

… Branch_Smooth_Sort

codecov-commenter · 2024-06-24T12:37:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.97%. Comparing base (f1e2606) to head (174de3f).
Report is 8 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #5236      +/-   ##
============================================
+ Coverage     40.67%   41.97%   +1.29%     
- Complexity     2502     2602     +100     
============================================
  Files           519      522       +3     
  Lines         15447    15542      +95     
  Branches       2949     2968      +19     
============================================
+ Hits           6283     6523     +240     
+ Misses         8869     8725     -144     
+ Partials        295      294       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vil02

At the moment the code is way too complex. I would suggest to:

implement LeonardoHeap (or use one of the existing implementations in heaps),
use it in the implementation of SmoothSort.

vil02 · 2024-06-24T16:58:40Z

src/main/java/com/thealgorithms/sorts/SmoothSort.java

+
+                    int indexOfRightChild = rootNodeIndices.get(j) - 1; // right child is of level n-2
+                    int indexOfLeftChild = rootNodeIndices.get(j) - 1 - getLeonardoNumbers()[currentLeonardoLevel - 2];
+                    if (array[prevRootNodeIndex].compareTo(array[indexOfRightChild]) > 0 && array[prevRootNodeIndex].compareTo(array[indexOfLeftChild]) > 0) {


As far as I see there is no test with array[prevRootNodeIndex].compareTo(array[indexOfRightChild]) > 0 evaluating to true and array[prevRootNodeIndex].compareTo(array[indexOfLeftChild]) > 0 to false.

To ensure that the logic is correct, please add a missing test.

Sure, I shall add a specific test case in SmoothSortTest.java.

I see why this is happening and I shall try my best to explain in this comment.

Leonardo Heap has the following three properties that define it (Going through the array from left to right):

The trees are in decreasing order of levels

Root nodes of the trees are in increasing order

Each tree is in a 'max-heap' state.

The Level-1 leonardo Tree(L1) and Level 0 leonardo Tree (L0) are the 'base case' trees as they have exactly one node.

At any given valid leonardo heap, if the heap contains both L1 and L0 tree then the element in L0 tree will always be greater than element at L1 tree, because of the second property mentioned above ( L0 >= L1 )

When L2 tree is being constructed, the level0 tree becomes the right child level1 tree becomes the left child. And hence it is not possible to have a condition such that level0 < prevRootNodeVal < level1 as it would be a voilation of the above.

This section of the wiki page and this article (under the imageAn erroneous swap ) mention that root needs to be bigger than the new element and the roots of its child nodes for a swap to happen. However this article(in page 6) mentions that the preRootValue should exceede its largest son.

I believe the statement in wiki is more genreic statement than a technical one and this condition can be optimized to just having array[prevRootNodeIndex].compareTo(array[indexOfLeftChild]) > 0. I shall however look around for more articles that suggest otherwise before I make changes to this.

src/main/java/com/thealgorithms/sorts/SmoothSort.java

vil02 · 2024-06-24T17:03:43Z

src/main/java/com/thealgorithms/sorts/SmoothSort.java

+                    leonardoTreeLevelforHeapify = currentLeonardoTreeLevels[j - 1];
+                }
+                j = j - 1;
+                if (j == i - 1) {


j == i - 1 is never false (among the existing test cases).

I do have a test case (not currently committed) with around 900 entries where this evalueates to false during creation of the heap. I can try to reduce the entires in such a way that the condition still evaluates to true, I will for sure end up having an array of size 20-30 ( as i will need 3 trees of non consecutive levels .... L1 L3 and L5 at least ).

Would it be fine if I added a test case in SmoothSortTest.java with around 20-30 elements in the test? If yes, I shall work on it at the very end after resolving the other conversations.

Update: Yes, this condition is never false. I belive what I intented to do was run maxHeapifyLeonardoTree if you reached the left most tree and further swaps are still present.

I am checking this as well.

src/main/java/com/thealgorithms/sorts/SmoothSort.java

JAPNITSINGH · 2024-06-25T05:37:57Z

At the moment the code is way too complex. I would suggest to:

implement LeonardoHeap (or use one of the existing implementations in heaps),

use it in the implementation of SmoothSort.

I did try to use existing implementaions of Heaps, however Leonardo Heap is a bit different from the others since this heap contains multiple loenardo trees of very specific shapes and the root node being the right most elemnent in the list.

I can crate a new class LeonardoHeap in heaps, however I believe I might not endup using the interface Heap.java in this implementation, would that be alright?

… Branch_Smooth_Sort

JAPNITSINGH · 2024-07-16T03:51:46Z

Hi @vil02 , are any further changes required in the test cases? Or in the code perhaps?

src/main/java/com/thealgorithms/sorts/SmoothSort.java

src/main/java/com/thealgorithms/datastructures/heaps/LeonardoHeap.java

vil02 · 2024-07-17T19:30:28Z

src/main/java/com/thealgorithms/datastructures/heaps/LeonardoHeap.java

+    private static ArrayList<Integer> findConsecutiveLeonardoTreeIndices(int num) {
+        int prevOneIndex = -1;
+        int currentLevel;
+
+        ArrayList<Integer> answer = new ArrayList<Integer>();
+        answer.add(-1);
+        answer.add(-1);
+
+        for (int i = 0; num > 0; i++) {
+            currentLevel = num & 1;
+            if (currentLevel == 1) {
+                if (prevOneIndex != -1) {
+                    answer.set(0, prevOneIndex);
+                    answer.set(1, i);
+                }
+                prevOneIndex = i;
+            } else {
+                prevOneIndex = -1;
+            }
+            num >>>= 1;
+        }
+        return answer;
+    }


This should be move to a separate class.

I can create a new class for this, probably with the name of LeonardoTreeHelper.java and add it's respective test file.

The other thing that can be done is that we can move this function to one of the bit manipulation classes? Since all this function is doing is returning first pair of indixes of consecutive 1 bits in an integer.

Which among these seems the right option @vil02?

@JAPNITSINGH sorry, this was my mistake. I somehow thought that this computes the Leonardo lumbers. Please move these two methods back to the LeonardoHeap. Sorry for the confusion.

JAPNITSINGH · 2024-07-18T08:57:16Z

Pushed some changes, I am yet to push some more. I will request review once done.

… Branch_Smooth_Sort

JAPNITSINGH · 2024-07-19T09:04:23Z

Hi @vil02 I have made the changes listed below and needed a few inputs:

Changes:

Used for-each loop in SmoothSort.java
Removed leonardoHeapSize
Removed redundant leonardo prefix in LeonardoHeap.java
Moved the initialization outside the constructor in LeonardoHeap.java
Removed getHeapsize method.
Modified LeonardoHeapTest.java to provide 100% coverage on running mvn clean && mvn test -Dtest=LeonardoHeapTest

I wanted your inputs on this part: I have added a LeonardoHeapHelper.java class where I have moved findConsecutiveLeonardoTreeIndices and findAllTreeIndices to the Helper class. I wanted to know if this class( and it's function names) should be renamed and moved to the bitwise operations package, or do you wish to place them else where.

For context :
findConsecutiveLeonardoTreeIndices takes in a number as an input and returns the indeices first occourence of consecutive 1 bits in it's binary form.
findAllTreeIndices takes in a number as an input and returns all bits that are 1 in it's binary form (in decending order)

src/main/java/com/thealgorithms/datastructures/heaps/LeonardoHeap.java

vil02 · 2024-07-19T15:45:24Z

src/main/java/com/thealgorithms/datastructures/heaps/LeonardoHeap.java

+    private static ArrayList<Integer> findConsecutiveLeonardoTreeIndices(int num) {
+        int prevOneIndex = -1;
+        int currentLevel;
+
+        ArrayList<Integer> answer = new ArrayList<Integer>();
+        answer.add(-1);
+        answer.add(-1);
+
+        for (int i = 0; num > 0; i++) {
+            currentLevel = num & 1;
+            if (currentLevel == 1) {
+                if (prevOneIndex != -1) {
+                    answer.set(0, prevOneIndex);
+                    answer.set(1, i);
+                }
+                prevOneIndex = i;
+            } else {
+                prevOneIndex = -1;
+            }
+            num >>>= 1;
+        }
+        return answer;
+    }


@JAPNITSINGH sorry, this was my mistake. I somehow thought that this computes the Leonardo lumbers. Please move these two methods back to the LeonardoHeap. Sorry for the confusion.

vil02 · 2024-07-19T16:00:47Z

src/main/java/com/thealgorithms/datastructures/heaps/LeonardoHeap.java

+        int currentRootNodeIndex = rootNodeIndex;
+        int rightChildIndex = rootNodeIndex - 1;
+        int leftChildIndex = rootNodeIndex - LeonardoNumber.leonardoNumber(currentLevel - 2) - 1;
+        int childIndexForSwap = -1;
+


Suggested change

int currentRootNodeIndex = rootNodeIndex;

int rightChildIndex = rootNodeIndex - 1;

int leftChildIndex = rootNodeIndex - LeonardoNumber.leonardoNumber(currentLevel - 2) - 1;

int childIndexForSwap = -1;

final int rightChildIndex = rootNodeIndex - 1;

final int leftChildIndex = rootNodeIndex - LeonardoNumber.leonardoNumber(currentLevel - 2) - 1;

final int childIndexForSwap = (heap.get(rightChildIndex).compareTo(heap.get(leftChildIndex)) >= 0) ? rightChildIndex : leftChildIndex;

final int currentRootNodeIndex = rootNodeIndex;

Yes, the formatting in this repo is ugly.

vil02 · 2024-07-19T16:02:25Z

src/main/java/com/thealgorithms/datastructures/heaps/LeonardoHeap.java

+        }
+    }
+
+    private void shiftRootAndRestoreHeap() {


Do you see some change to chop this method into few smaller ones?

Might be possible, I'll take a look into using some form of recursion instead of the while loop I am using. Recursion might give a bit more readability.

I would suggest to refactor this method into a shorter one.

vil02 · 2024-07-19T16:02:44Z

src/main/java/com/thealgorithms/datastructures/heaps/LeonardoHeap.java

+
+        int rootNodeIndexForHeapify = rootNodeIndices.getLast();
+        int treeLevelforHeapify = currentTreeLevels[currentTreeLevels.length - 1];
+        boolean swaped = false;


Suggested change

boolean swaped = false;

boolean swapped = false;

You can consider moving this declaration into the loop (smaller scope is always better). This should work, because this variable is always false at the end of of each loop.

vil02 · 2024-07-19T16:10:11Z

src/main/java/com/thealgorithms/datastructures/heaps/LeonardoHeap.java

+    private void swap(int i, int j) {
+        T temp = heap.get(i);
+        heap.set(i, heap.get(j));
+        heap.set(j, temp);
+    }


Suggested change

private void swap(int i, int j) {

T temp = heap.get(i);

heap.set(i, heap.get(j));

heap.set(j, temp);

}

private void swap(final int i, final int j) {

Collections.swap(heap, i, j);

}

make sure to

import java.util.Collections;

vil02 · 2024-07-19T16:10:33Z

src/main/java/com/thealgorithms/datastructures/heaps/LeonardoHeap.java

+
+    public T removeElement() {
+        decreaseLevelTracker();
+        T element = heap.removeLast();


Suggested change

T element = heap.removeLast();

final T element = heap.removeLast();

JAPNITSINGH · 2024-07-22T13:42:34Z

Pushed some changes removed the Helper class and added final access modifier to variable that weren't subject to change, I am yet to push some more changes (that is the changes to shiftRootAndRestoreHeap ). I will request review once done.

JAPNITSINGH · 2024-07-24T05:22:42Z

Hey @vil02 , I have made some changes:

removed the Helper class
added final access modifier to variable that weren't subject to change
Added a few more functions to split shiftRootAndRestoreHeap into smaller chuncks make the code more readable

I tried to get rid of the while loop and use recursion but I ran into problem where I wanted the function to return two things rootNodeIndexForHeapify and treeLevelforHeapify, and I coulnd't achieve that in a clean way. So the loop exists in the code for now and I have optimized the way I used swapped (now renamed to swapRequired)

JAPNITSINGH · 2024-08-02T13:02:55Z

Hi @vil02, would you kindly have a look and let me know if there are more changes to be made?

src/main/java/com/thealgorithms/datastructures/heaps/LeonardoHeap.java

vil02 · 2024-08-06T06:52:50Z

src/main/java/com/thealgorithms/datastructures/heaps/LeonardoHeap.java

+        }
+    }
+
+    private void shiftRootAndRestoreHeap() {


I would suggest to refactor this method into a shorter one.

vil02 · 2024-08-06T06:55:29Z

src/test/java/com/thealgorithms/datastructures/heaps/LeonardoHeapTest.java

+    @Test
+    public void testRemoveElement() {
+        LeonardoHeap<Integer> heap = new LeonardoHeap<>();
+        heap.addElement(10);
+        heap.addElement(20);
+        heap.addElement(5);
+
+        assertEquals(20, heap.removeElement());
+        assertEquals(10, heap.removeElement());
+        assertEquals(5, heap.removeElement());
+    }
+
+    @Test
+    public void testAddElementStrings() {
+        LeonardoHeap<String> heap = new LeonardoHeap<>();
+        heap.addElement("z");
+        heap.addElement("a");
+        heap.addElement("x");
+        heap.addElement("b");
+        heap.addElement("y");
+
+        assertEquals("z", heap.removeElement()); // Max element should be z
+        assertEquals("y", heap.removeElement());
+        assertEquals("x", heap.removeElement());
+        assertEquals("b", heap.removeElement());
+        assertEquals("a", heap.removeElement());
+    }
+
+    @Test
+    public void testRemoveElementString() {
+        LeonardoHeap<String> heap = new LeonardoHeap<>();
+        heap.addElement("z");
+        heap.addElement("a");
+        heap.addElement("x");
+
+        assertEquals("z", heap.removeElement());
+        assertEquals("x", heap.removeElement());
+        assertEquals("a", heap.removeElement());
+    }
+
+    @Test
+    public void testAlwaysCurrentMaxElementIsRemoved() {
+        LeonardoHeap<Integer> heap = new LeonardoHeap<>();
+        heap.addElement(5);
+        heap.addElement(8);
+        heap.addElement(7);
+        heap.addElement(3);
+
+        heap.addElement(4);
+        heap.addElement(4);
+        heap.addElement(4);
+        heap.addElement(6);
+
+        heap.addElement(8);
+        heap.addElement(8);
+
+        assertEquals(8, heap.removeElement());
+        assertEquals(8, heap.removeElement());
+        assertEquals(8, heap.removeElement());
+        assertEquals(7, heap.removeElement());
+
+        assertEquals(6, heap.removeElement());
+        assertEquals(5, heap.removeElement());
+        assertEquals(4, heap.removeElement());
+        assertEquals(4, heap.removeElement());
+
+        assertEquals(4, heap.removeElement());
+        assertEquals(3, heap.removeElement());
+    }
+
+    @Test
+    public void testForCompareChildAndSwap() {
+        LeonardoHeap<Integer> heap = new LeonardoHeap<>();
+        Integer[] elements = {5, 33, 40, 28, 95, 29, 88, 94, 12, 84, 15, 33, 2, 52, 37, 62, 48, 13, 61, 59};
+
+        for (Integer element : elements) {
+            heap.addElement(element);
+        }
+
+        assertEquals(95, heap.removeElement());
+        assertEquals(94, heap.removeElement());
+        assertEquals(88, heap.removeElement());
+        assertEquals(84, heap.removeElement());
+        assertEquals(62, heap.removeElement());
+        assertEquals(61, heap.removeElement());
+        assertEquals(59, heap.removeElement());
+        assertEquals(52, heap.removeElement());
+        assertEquals(48, heap.removeElement());
+        assertEquals(40, heap.removeElement());
+        assertEquals(37, heap.removeElement());
+        assertEquals(33, heap.removeElement());
+        assertEquals(33, heap.removeElement());
+        assertEquals(29, heap.removeElement());
+        assertEquals(28, heap.removeElement());
+        assertEquals(15, heap.removeElement());
+        assertEquals(13, heap.removeElement());
+        assertEquals(12, heap.removeElement());
+        assertEquals(5, heap.removeElement());
+        assertEquals(2, heap.removeElement());
+    }


I added some more assertEquals here. A test, which does not assert can lead to confusion. Please have a look if it makes sense to parametrize these tests.

The LeonardoHeap misses a method isEmpty(). There is simply no way to know if user cans still removeElement.

@vil02 , I had a public heap size function earlier which was being used to check if the heap is empty (or heap size is 0). It was removed in one of the previous conversations. I can explicitly add an isEmpty() function instead of the heap size one.

@JAPNITSINGH what can I say: it is my bad. Sorry for that. But honestly: I think having a isEmpty() method makes sense.

Alright, I'll make the changes in a couple of days and update here.

JAPNITSINGH · 2024-08-26T15:10:08Z

Hi @vil02 , I need a liitle more time to complete the tasks, I am a bit occupird with my college. I shall update here as soon as I get time to cmplete this.

JAPNITSINGH added 7 commits May 28, 2024 14:29

Adding Skeleton

9e5cb32

Understanding Heap Sort

9ff4e85

Implement merge sort

69b24a8

next step is to improve it to leonardo sort

Smooth Sort impl, needs cleaning.

6de4059

Added test cases, improved code coverage.

d6a14b6

Refactorization of code

384f814

Merge branch 'TheAlgorithms:master' into Branch_Smooth_Sort

29252e1

JAPNITSINGH requested review from yanglbme, vil02 and BamaCharanChhandogi as code owners June 18, 2024 09:37

JAPNITSINGH added 3 commits June 18, 2024 15:24

Fixed brackets and ran mvn checkstyle:checkstyle to ensure no more ch…

4f0fd70

…eckstyle faults

Fixed a tab space issue

0cdcba2

Removed useless parenthesis.

d32e435

vil02 requested changes Jun 18, 2024

View reviewed changes

JAPNITSINGH added 3 commits June 24, 2024 18:04

Re work, fix bugs, names etc.

712868e

Merge branch 'TheAlgorithms:master' into Branch_Smooth_Sort

368db8a

Merge branch 'Branch_Smooth_Sort' of github.com:JAPNITSINGH/Java into…

5f9d2e7

… Branch_Smooth_Sort

JAPNITSINGH added 3 commits June 24, 2024 18:21

Forgot to add test file

990b183

Improved code coverage yo 99.9%

0eda98e

Removed the break statement to improve code coverage.

aed3358

vil02 requested changes Jun 24, 2024

View reviewed changes

JAPNITSINGH added 6 commits June 25, 2024 17:09

Removed comments and used SortUtils

ab905bf

Merge branch 'TheAlgorithms:master' into Branch_Smooth_Sort

65ca159

Merge branch 'Branch_Smooth_Sort' of github.com:JAPNITSINGH/Java into…

d5e3b95

… Branch_Smooth_Sort

Use SingleBitOperations class.

ec02a6c

Conditional changes on when to call max_heapify.

b19bd38

Skeleton of LeonardoHeap.java

5d21701

JAPNITSINGH added 4 commits July 8, 2024 14:19

Added LeonardoHeapTest.java

1adbd15

Merge branch 'Branch_Smooth_Sort' of github.com:JAPNITSINGH/Java into…

c249579

… Branch_Smooth_Sort

UMTP_UNBOUND_METHOD_TEMPLATE_PARAMETER mvn spotbug fix

edbf08a

Merge branch 'master' into Branch_Smooth_Sort

cf1ce78

JAPNITSINGH requested a review from vil02 July 12, 2024 04:21

Merge branch 'master' into Branch_Smooth_Sort

369cbeb

vil02 requested changes Jul 17, 2024

View reviewed changes

JAPNITSINGH added 3 commits July 18, 2024 13:58

Rename members and add tests

01ba460

pmd errors fix

fa0797f

spotbug fix

ba730d0

JAPNITSINGH added 3 commits July 19, 2024 14:17

Added LeonardoHeapHelper.java

a8a5835

Merge branch 'TheAlgorithms:master' into Branch_Smooth_Sort

5093f86

Merge branch 'Branch_Smooth_Sort' of github.com:JAPNITSINGH/Java into…

761b848

… Branch_Smooth_Sort

vil02 requested changes Jul 19, 2024

View reviewed changes

JAPNITSINGH added 2 commits July 22, 2024 19:02

Removed Helper Class, formatted to make items final.

37c794b

Rework on formatting.

c0b8737

JAPNITSINGH added 2 commits July 24, 2024 10:39

Reworking LeonardoHeap: shiftRootAndRestoreHeap

ad4c540

Lint issues in LeonardoHeap

0edabcd

JAPNITSINGH requested a review from vil02 July 24, 2024 05:22

vil02 reviewed Aug 6, 2024

View reviewed changes

src/main/java/com/thealgorithms/datastructures/heaps/LeonardoHeap.java Outdated Show resolved Hide resolved

vil02 added 2 commits August 6, 2024 08:37

style: use predecrement operator

6b4c415

tests: add more checks into tests

174de3f

vil02 requested changes Aug 6, 2024

View reviewed changes

	T element = heap.removeLast();
	final T element = heap.removeLast();

Implement Smooth Sort #5236

Are you sure you want to change the base?

Implement Smooth Sort #5236

Conversation

JAPNITSINGH commented Jun 18, 2024

JAPNITSINGH commented Jun 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JAPNITSINGH Jun 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Jun 24, 2024 • edited Loading

Codecov Report

vil02 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JAPNITSINGH Jun 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JAPNITSINGH Jun 25, 2024 • edited Loading

Choose a reason for hiding this comment

JAPNITSINGH Jun 25, 2024 • edited Loading

Choose a reason for hiding this comment

JAPNITSINGH commented Jun 25, 2024 • edited Loading

JAPNITSINGH commented Jul 16, 2024

Choose a reason for hiding this comment

JAPNITSINGH Jul 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JAPNITSINGH commented Jul 18, 2024

JAPNITSINGH commented Jul 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JAPNITSINGH commented Jul 22, 2024

JAPNITSINGH commented Jul 24, 2024

JAPNITSINGH commented Aug 2, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JAPNITSINGH commented Aug 26, 2024

JAPNITSINGH Jun 22, 2024 •

edited

Loading

codecov-commenter commented Jun 24, 2024 •

edited

Loading

JAPNITSINGH Jun 25, 2024 •

edited

Loading

JAPNITSINGH Jun 25, 2024 •

edited

Loading

JAPNITSINGH Jun 25, 2024 •

edited

Loading

JAPNITSINGH commented Jun 25, 2024 •

edited

Loading

JAPNITSINGH Jul 18, 2024 •

edited

Loading