-
Notifications
You must be signed in to change notification settings - Fork 18.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTHER] Cleanup classes with very strange design #5164
Comments
Hey, I am working on "ArrayCombination" |
Hello I´m new here and I would like to help !!! |
@JeysiStrokk would you like to work on |
@vil02 I´ll gladly do it. I´ll try my best !! Thanks a lot !! |
I´m working on "LetterCombinationsOfPhoneNumber" |
I´m working on "StringMatchFiniteAutomata" |
I´m working on "ColumnarTranspositionCipher" |
Sorry, I refactored this class without seeing that you had already started. Now I saw in your repository that you only added the comments in the class. That's why I make the pull request. |
I´m working on "Combination" |
* Related to #5164 (Redesign of ArrayCombination) * Checkstyle fix * Clang_format * refactor: cleanup --------- Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com> Co-authored-by: vil02 <vil02@o2.pl>
Can I work on "Combination", or "AllPathsFromSourceToTarget"? I know in the comments people were supposed to have worked on this, but they aren't marked as complete, so if they still need work I'd be happy to work on one of them. |
@AbeTheAmatuer Sure, feel free to work on them! |
Thanks, I'll work on Combination. |
@siriak I did some cleanup for Combination. It was mostly fine, so I just changed the class name to, "CombinationGenerator", added some comments and changed a variable name for accuracy. I made a PR. Edit: Ok so changing the class name impacted a bunch of other files so I changed it back and closed my pull request but I fixed the problem and am not sure how to make another one. |
@AbeTheAmatuer please have a look at:
by @samuelfac - these PR are in the stage almost to be merged. I am not sure if @samuelfac is planning to continue to work on them - it would be a pity if not.. |
@vil02 Ok, do you want me to just review his commits? |
Hey, I am working on Combination |
Hey, can I help and Contribute in something ? |
hey im working on AllPathsFromSourceToTarget |
What would you like to share?
There are probably many classes in this repository, which have some strange design - we should update all of them. I think we can start with cleaning up these:
List of the classes needing redesign:
AllPathsFromSourceToTarget
ArrayCombination
(refactor: redesignArrayCombination
#5181 by @yuvashreenarayanan3)Combination
ColumnarTranspositionCipher
(Refactor: redesign ColumnarTranspositionCipher #5223 by @samuelfac)StringMatchFiniteAutomata
(refactor: redesignStringMatchFiniteAutomata
#5222 by @samuelfac)LetterCombinationsOfPhoneNumber
(refactor: redesignLetterCombinationsOfPhoneNumber
#5221 by @samuelfac)(@siriak, @BamaCharanChhandogi feel free to edit the list above)
Additional information
How to contribute
XYZ
", whereXYZ
is your selected class,cleanup_XYZ
,Also feel free to suggest a class, which should be added to the list above.
The text was updated successfully, but these errors were encountered: