-
Notifications
You must be signed in to change notification settings - Fork 18.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTHER] Enable more checks in checkstyle #5119
Comments
I will work on |
Hey, I will be working on |
Now, I will be working on |
I will work on |
I will slowly work on |
Hey, I will be working on MethodName |
I will work on |
I will work on |
@siriak, @BamaCharanChhandogi I have extended the list of obvious checks. Please have a look and edit the list if needed. |
Hi, I will be working on FinalClass. |
I will work on EqualsHashCode. |
I will work on InnerAssignment. |
I will work on MethodName. |
Hey, I'll be working on |
@cpu-pixel Thanks for spotting that! |
Hey, I'll be working on TypeName. |
I'll be working on |
I will work on ParameterName. |
I will work on . |
I will work on . |
I will work on ParenPad. |
I will work on |
I will work on |
I will work on |
|
Please have a look at #5241. But you are right: some of the checks (like |
I will work on enabling the |
Hey Can I work on something ? |
@adityasarfare sure, see what checks are disabled with todo and feel free to enable them one-by-one https://github.com/TheAlgorithms/Java/blob/master/checkstyle.xml |
Hey, I am working on NoWhitespaceAfter |
Looks like NoWhitespaceAfter is conflicting with clang-format missed the earlier comment , closing the PR |
What would you like to share?
#5110 introduced checkstyle. The config file has some of the rules commented out. It might a good idea to introduce some of them and discuss why the other ones are not needed in this repository.
List of checks which should be introduced
Few of the obvious checks, which should be introduced:
ConstantName
in checkstyle #5139 by @marysiuniq)LocalVariableName
in CheckStyle #5191 by @cpu-pixel)MemberName
in checkstyle #5193 by @cpu-pixel)MethodName
in CheckStyle #5182 by @CodaBlurd)ParameterName
in CheckStyle. #5196 by @CodaBlurd)StaticVariableName
in checkstyle #5173 by @vaibhav9t1)TypeName
#5214 by @StarDxxx)AvoidStarImport
in checkstyle #5141)ModifierOrder
in checkstyle #5132 by @marysiuniq)RedundantModifier
in checkstyle #5140)EmptyStatement
#5120)MultipleVariableDeclarations
in checkstyle #5175 by @vaibhav9t1)HideUtilityClassConstructor
in checkstyle #5147)ArrayTypeStyle
in checkstyle #5145)InvalidJavadocPosition
in checkstyle #5237 by @samuelfac)OperatorWrap
in checkstyle #5212 by @StarDxxx)ParenPad
in checkstyle #5226 by @samuelfac)InnerAssignment
in checkstyle #5162 by @CodaBlurd)FinalClass
in checkstyle #5154 by @CodaBlurd)MissingSwitchDefault
in checkstyle #5179 by @BamaCharanChhandogi)NeedBraces
in checkstyle #5227 by @samuelfac)AvoidNestedBlocks
in checkstyle #5228 by @samuelfac)WhitespaceAround
in checktyle #5241)(@siriak, @BamaCharanChhandogi feel free to edit the list above)
Additional information
How to contribute
XYZ
", whereXYZ
is your selected check,XYZ
check in thecheckstyle.xml
,mvn checkstyle:check
and fix all of the errors - please keep your changes minimal,XYZ
in checkstyle",The text was updated successfully, but these errors were encountered: