Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new fft algorithm #2703

Closed
wants to merge 14 commits into from
Closed

Conversation

ikocs
Copy link

@ikocs ikocs commented Jun 27, 2024

Description of change A new direct and inverse fast Fourier transform algorithm has been added. The new algorithm uses templates. During development,

Checklist

  • Added description of change
  • Added filename conforms to filename guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments are changed or added
  • PR title follows semantic commit guidelines
  • Search previous commits before making a new one, as yours may be a duplicate
  • I acknowledge that all my contributions are made under the project's licence.

Notes: I also discovered that the old algorithm did not work correctly, and the test data was entered incorrectly. An independent check can be carried out using an online calculator.

I suggest replacing the old files with new ones, but have not yet removed them from the repository.

Copy link
Contributor

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Jul 28, 2024
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!

@github-actions github-actions bot closed this Aug 5, 2024
@ikocs
Copy link
Author

ikocs commented Aug 5, 2024

@Panquesito7 @realstealthninja Good afternoon, please conduct a review
thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Author has not responded to the comments for over 2 weeks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant