Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compilation failure with gcc >= 13 #2702

Merged
merged 2 commits into from
Aug 31, 2024

Conversation

VirtualTim
Copy link
Contributor

@VirtualTim VirtualTim commented Jun 21, 2024

Description of Change

It appears that gcc13 reordered some headers, so iostream no longer includes cstdint.
Files using cstdint via iostream need to be updated.
I've only changed one file, but there's sure to be more that need changing (see #2698).

Checklist

  • Added description of change
  • PR title follows semantic commit guidelines
  • I acknowledge that all my contributions will be made under the project's license.

Notes: For testing - https://godbolt.org/z/6WWh3zs9G

Copy link
Contributor

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Jul 22, 2024
@VirtualTim
Copy link
Contributor Author

@Panquesito7?

@github-actions github-actions bot removed the stale Author has not responded to the comments for over 2 weeks label Jul 26, 2024
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me I'll raise this as an issue

@realstealthninja realstealthninja added bugfix Correction to existing algorithms 1st Review: Passed labels Aug 21, 2024
@realstealthninja realstealthninja added the dont-close This issue/pull request shouldn't be closed label Aug 28, 2024
@realstealthninja realstealthninja merged commit 4a03c62 into TheAlgorithms:master Aug 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1st Review: Passed bugfix Correction to existing algorithms dont-close This issue/pull request shouldn't be closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants