Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix bug in timSort #2692

Merged
merged 11 commits into from
Sep 1, 2024
Merged

fix: fix bug in timSort #2692

merged 11 commits into from
Sep 1, 2024

Conversation

MaximSmolskiy
Copy link
Contributor

@MaximSmolskiy MaximSmolskiy commented Apr 23, 2024 •
edited
Loading

Description of Change

Fix #2687

Checklist

  • Added description of change
  • Added tests and example, test must pass
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@MaximSmolskiy
Copy link
Contributor Author

@Panquesito7 @realstealthninja please review

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Jun 11, 2024
@MaximSmolskiy
Copy link
Contributor Author

@Panquesito7 @realstealthninja please review

@github-actions github-actions bot removed the stale Author has not responded to the comments for over 2 weeks label Jul 26, 2024
realstealthninja
realstealthninja requested changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution.

The test function should not have a parameter

sorting/tim_sort.cpp Outdated Show resolved Hide resolved
sorting/tim_sort.cpp Outdated Show resolved Hide resolved
sorting/tim_sort.cpp Outdated Show resolved Hide resolved
sorting/tim_sort.cpp Outdated Show resolved Hide resolved
MaximSmolskiy and others added 2 commits August 23, 2024 01:02
@MaximSmolskiy @realstealthninja
Apply suggestions from code review
f238dd1 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@MaximSmolskiy
Fix
165d83a
@MaximSmolskiy
Copy link
Contributor Author

@Panquesito7 @realstealthninja please review

realstealthninja
realstealthninja requested changes Aug 23, 2024
View reviewed changes
sorting/tim_sort.cpp Outdated Show resolved Hide resolved
realstealthninja
realstealthninja approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions

@realstealthninja realstealthninja added bugfix Correction to existing algorithms 1st Review: Passed labels Aug 23, 2024
@realstealthninja
Copy link
Collaborator

unable to merge, will resolve in a day or two! sorry for the delay.

@realstealthninja
Copy link
Collaborator

since i was the last one to push an update to this pr im unable to merge this. Could you find something to commit to this file?

realstealthninja
realstealthninja approved these changes Sep 1, 2024
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@realstealthninja realstealthninja merged commit db182d5 into TheAlgorithms:master Sep 1, 2024
7 checks passed
@MaximSmolskiy MaximSmolskiy deleted the fix-bug-in-timSort branch September 2, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realstealthninja realstealthninja realstealthninja approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

Assignees
No one assigned
Labels
1st Review: Passed bugfix Correction to existing algorithms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] timsort - std::bad_array_new_length
2 participants
@MaximSmolskiy @realstealthninja