Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Iterative Quick Sort #2684

Merged
merged 14 commits into from
Sep 4, 2024

Conversation

sebe324
Copy link
Contributor

@sebe324 sebe324 commented Mar 21, 2024

Description of Change

I've added an implementation of iterative quick sort.
It uses the stack instead of recursion.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

Copy link
Contributor

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Apr 21, 2024
@sebe324
Copy link
Contributor Author

sebe324 commented Apr 21, 2024

can someone check this pr out? @realstealthninja

@github-actions github-actions bot removed the stale Author has not responded to the comments for over 2 weeks label Jul 26, 2024
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean documentation. Well written too! Thank you for this contribution ♥️

sorting/quick_sort_iterative.cpp Outdated Show resolved Hide resolved
sorting/quick_sort_iterative.cpp Outdated Show resolved Hide resolved
sorting/quick_sort_iterative.cpp Outdated Show resolved Hide resolved
sebe324 and others added 3 commits September 2, 2024 16:25
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@realstealthninja realstealthninja added the automated tests are failing Do not merge until tests pass label Sep 2, 2024
@realstealthninja
Copy link
Collaborator

Tests failing! The issue is the functions youre using inside test is not the namespaced one

Fix is prefixing the function calls with

   sorting::function_name()

@sebe324
Copy link
Contributor Author

sebe324 commented Sep 3, 2024

Oh I forgot, I'll fix it later today.

Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@realstealthninja realstealthninja merged commit ef209df into TheAlgorithms:master Sep 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated tests are failing Do not merge until tests pass requested changes changes required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants