-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove memory leak iterative_factorial.cpp
#2535
fix: remove memory leak iterative_factorial.cpp
#2535
Conversation
@vil02, some suggestions.. pls resolve the conflits |
4fe4cf4
to
e4ada59
Compare
@CarlosZoft luckily there were no conflicts, just my branch was out-of-date. It is fixed now. |
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@Panquesito7, @realstealthninja: Merry Christmas and please |
e4ada59
to
a86a017
Compare
a86a017
to
443d2ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Please add |
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I still think this PR is valuable. |
@vil02 no more don't closing cause I'm merging it |
Description of Change
There is a memory leak in
iterative_factorial.cpp
while throwing an exception. This PR fixes it and does some other small changes.Checklist
Added file name matches File name guidelinesAdded tests and example, test must passAdded documentation so that the program is self-explanatory and educational - Doxygen guidelinesRelevant documentation/comments is changed or addedNotes:
Removes memory leak in
iterative_factorial.cpp
.