-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added LeetCode problem 1,2 #2450
base: master
Are you sure you want to change the base?
Conversation
Created new directory for leetcode solutions
- name: Write LeetCode DIRECTORY.md | ||
run: | | ||
python3 scripts/leetcode_directory_md.py 2>&1 | tee leetcode/DIRECTORY.md | ||
git pull || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, this is not needed if we use fetch-depth
in actions/checkout
.
CC: @tjgurwara99.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is not needed.
Co-authored-by: David Leal <halfpacho@gmail.com>
* Updated the leetcode Readme.md file
Hi @Panquesito7, @tjgurwara99 /home/runner/work/C-Plus-Plus/C-Plus-Plus/leetcode/src/2.cpp:29:9: warning: assigning newly created 'gsl::owner<>' to non-owner 'ListNode *' [cppcoreguidelines-owning-memory] I guess it is because of the use of raw pointers instead of smart pointers. Is there a way to suppress this? (This may require changing the definition of the ListNode struct, which is already defined by the platform) struct ListNode { |
Does this directory also fall under doxygen style guidelines? |
I believe so. Not required, but if added, it's better, IMO. |
It'd be better to use smart pointers, though. |
Ah alright! |
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions! |
Created new directory for leetcode solutions, updated DIRECTORY.md and README.md
Description of Change
Checklist
Notes: