add soul event infrastructure for boss fight #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also forgot to add `soul_0_sword` to this list, so add it now
- it can loop endlessly now that we connect all 3 phases (`attack`, `soul`, `warn`) so having a function call to end it is crucial
…function - attack phase didn't follow this pattern, so fix it
…an differentiate between it and the soul event's tv_screen model
- used in boss fight soul phase initializer function so we don't delete both soul + boss_fight tv_screen modelsn when we only want to delete one of them
- not connected to other phases, that's coming in next commit
- `warn` -> `soul` -> `attack` - add missing comment in attack terminate function
- add to boss fight director logic
- images taken straight from the sprite sheet
- adjust length of attack phase 1 for the sounds to line up better - the warning/static sounds were too close together before
- -75 blocks in z-direction of main arena
TheAfroOfDoom
force-pushed
the
soul-event-infrastructure
branch
from
54b95e9 to
e4811c1
Compare
…ess instead of having its own clock
- red (default), blue, cyan, green, magenta, orange, yellow variants - animations: `float`, `shake`
- e.g. cyan: 0, orange: 1, etc.
- also adjust animation positions so it moves accordingly
…ight phase - also rename `soul.soul` tag to `soul.soul_event` for extra clarity
…rately position `soul` model
…ge (float more) - more accurate to Undertale's look
…s before starting
- before, had to wait for indicator to finish de-animating/terminating - now, we check for X flies to be remaining in order to trigger the next boss fight's attack
… more detailed later
TheAfroOfDoom
force-pushed
the
soul-event-infrastructure
branch
from
b3b17ce to
a0d30c5
Compare
TheAfroOfDoom
changed the title
TheAfroOfDoom
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Split from #83
This PR adds the logic, visuals, and sounds required for the soul-event phase of the boss fight.
In #26 we added the base infrastructure for the boss-fight. From that PR:
We expand that list of steps in this PR with:
boss-fight.progress.phase.ihas_active_soul_eventtag) (next PR)This PR also adds new models/animations to supplement the new soul event phase.
Test plan
N/A
Reproducing in-game
Preview
video of transition from attack phase to soul event phase
models
tv_screenmodeltv_screen-- static variantsoul--redsoul--0soul--1soul--2soul--3soul--4soul--5animations
full
WARNINGanimationsoul--shakesoul--floattv_screenwithsoulfloatingworld changes
new soul arena
Supplemental changes
datapack/testworkflow run regardless of ifdatapack/lintpasses --f36d384(#84)reset_scoresfunctions to run on/reload--d5ac716(#84)1a3a311(#84)26db866(#84)attack-fliestrigger next boss-fight attack sooner --1a73212(#84)remove_animated_java_models--a0d30c5(#84)