add mvp for flies attack
#77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tack initialization
- also fix offenders
- when a fly flies into the venus fly trap's mouth
…nated - also add tick delay to indicator termination so we can easily play a termination animation later
- crazy that its quality enough to reuse - even crazier that its still importable - downloaded from resourcepack: https://www.mediafire.com/file/4f4u8i0fg0aga7o/%2521OmegaFloweyBossFight%2521.zip/file
- happens as the housefly is terminating (going into the venus fly trap / indicator)
- included scratch work in a png
- being reworked in next commit(s) to be able to loop
- manually stop it at end of attack
- also add to phase 1 of boss fight
- was a weird bug where it wasn't working properly (triggering next attack) when it lived in executor - probably because the executor did all its actions in a single tick
…their region instead of total angle - scratch: https://www.desmos.com/calculator/7evdcc1qaz
- instead of having to manually copy the whole tellraw command for each error - convert all preexisting errors to use new util function
… exists - errors if both exist
- specifically happened when you'd start more than one flies attack in quick succession (e.g. 2 at once) - problem was that the fly was getting killed/terminated before running `entity:group/start` / `entity:group/end` and that caused jank
…value
- sample usage:
```
data merge storage utils:debug.set_name { name: 'group.id' }
execute store result storage utils:debug.set_name value int 1 run scoreboard players get @s group.id
function entity:utils/debug/set_name with storage utils:debug.set_name
```
- change direction indicators are facing -- diagonally across arena instead of west/east - move bullets position/hitbox up for better visual into the fly trap
- was reading scratch images - also move scratchwork text file into `scratch` directory
- housefly ajmodel has `"texture": null` for a bunch of cubes, but we were only filtering out `undefined` values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds most of the functionality for the fly attack. It includes:
housefly,venus-fly-trap)Later, after Flowey's vines surrounding the arena (models + animations) are added, we'll have to adjust the venus fly trap model/animation slightly to account for the vine models. We'll need to:
Notable commit(s):
88b7185(#77)This commit has some decently cool math with Desmos to determine the probability that a fly spawns on the top/bottom/side walls: https://www.desmos.com/calculator/7evdcc1qaz
Test plan
stilllll no unit tests
Reproducing in-game
Preview
model
fun fact: the
houseflymodel is the exact same model + texture as the one used in the original map. credit to @FLOATINGCRETINhouseflyvenus-fly-trapanimations
housefly--shrinkvenus-fly-trap--chompattack
videos with sound
Supplemental changes
sounds.json--300a468(#77)ticketize-todosnot requiring a colon:--0424aab(#77)entity:hostile/omega-floweyshortcut to workspace --6b024d4(#77).ajmodelfiles render as JSON --ee3e23c(#77)2736f0f(#77)5bd46fe(#77)100d1c9(#77)c6b2d47(#77)new issues:
in memoriamfor András Neltz in the credits #74