add unit tests for utils:math/vector/dot, omega-flowey:reset, and omega-flowey:setup
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- these aren't actually perfect but we're probably gonna just delete the dot function anyway so im not wasting more time on it
- two of them must be optional until we update to `packtest@v1.0.0-beta5+` - context: https://discord.com/channels/154777837382008833/1185733502294044802/1187227243861254164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds unit tests for:
utils:math/vector/dotomega-flowey:resetomega-flowey:setupNOTE: the tests for
utils:math/vector/dotrevealed that the function isn't perfect (it's non-commutative), but that's fine for now since it's unclear if we even want to use it (for thehoming-vinesattack's hitbox).This PR also updates to the fixed
packtest_runnerversion from CarbonSmasher/packtest_runner#1 that includes support for specifying a custompacktestversion to use (allowing us to update the variable for newpacktestfeatures instead of waiting onpacktest_runnerto update).Test plan
see Summary ^
unit tests pass
Reproducing in-game
In the modded client run:
Preview
N/A
Supplemental changes
N/A