Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate friendliness-pellets attack parameters #44

Open
TheAfroOfDoom opened this issue Dec 22, 2023 · 0 comments
Open

validate friendliness-pellets attack parameters #44

TheAfroOfDoom opened this issue Dec 22, 2023 · 0 comments
Labels
datapack Issues pertaining to the datapack validation validation that preexisting features are functioning and appear as clean as possible

Comments

@TheAfroOfDoom
Copy link
Owner

TheAfroOfDoom commented Dec 22, 2023

run the attack (individually and during a boss fight) and analyze how the following properties feel:

score parameters

in reset_scores.mcfunction:

https://github.com/TheAfroOfDoom/omega-flowey-minecraft-remastered/blob/69cdff31aaf2b4b1f1d1f8da4234e6bc85b1f03c/datapacks/omega-flowey/data/entity/functions/hostile/omega-flowey/attack/friendliness-pellets/reset_scores.mcfunction#L1-L10

most of these values should be solid, but double check anyway that they are accurate to Undertale's representation of the attack.

you can toy with attack.speed.z in particular to change the speed of the pellets once they activate. are they too fast? too slow?

attack.bullets.clock.delay may be off by one tick? this controls when the pellets activate (and move) after all pellets have been summoned. tbh i dont remember why i thought it might be off by one tick (0.05s), but just verify anyway that it's not. (it's really not a big deal even if it is, but i wrote it down as a TODO so 🤷‍♀️)

https://github.com/TheAfroOfDoom/omega-flowey-minecraft-remastered/blob/afb1cc943424e4145c365b8503f9b30655effa6f/datapacks/omega-flowey/data/entity/functions/hostile/omega-flowey/attack/friendliness-pellets/indicator/loop.mcfunction#L27-L29


this is very much a "feels-based" ticket -- lock down final values for these properties

@TheAfroOfDoom TheAfroOfDoom added enhancement New feature or request datapack Issues pertaining to the datapack labels Dec 22, 2023
TheAfroOfDoom added a commit that referenced this issue Dec 22, 2023
@TheAfroOfDoom TheAfroOfDoom added validation validation that preexisting features are functioning and appear as clean as possible and removed enhancement New feature or request labels Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datapack Issues pertaining to the datapack validation validation that preexisting features are functioning and appear as clean as possible
Projects
None yet
Development

No branches or pull requests

1 participant