Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameterize entity:utils/shake_screen's yaw/pitch ranges with macros #38

Open
TheAfroOfDoom opened this issue Dec 22, 2023 · 1 comment
Labels
chore stuff like code refactoring datapack Issues pertaining to the datapack enhancement New feature or request good first issue Good for newcomers

Comments

@TheAfroOfDoom
Copy link
Owner

currently its values are hard-coded:

  • yaw: 5..50 (tenth's of a degree, so 0.5..5 degrees)
  • pitch: 5..20 (tenth's of a degree, so 0.5..2 degrees)

TODO of this issue is to make this function take in macros (probably like yaw_min, yaw_max).

would also need to convert places that call this already to input parameter macros with the currently hard coded values (above)

https://github.com/TheAfroOfDoom/omega-flowey-minecraft-remastered/blob/afb1cc943424e4145c365b8503f9b30655effa6f/datapacks/omega-flowey/data/entity/functions/hostile/omega-flowey/attack/dentata-snakes/bullet/loop/bounce.mcfunction#L33

@TheAfroOfDoom TheAfroOfDoom added enhancement New feature or request datapack Issues pertaining to the datapack labels Dec 22, 2023
TheAfroOfDoom added a commit that referenced this issue Dec 22, 2023
@TheAfroOfDoom TheAfroOfDoom added the good first issue Good for newcomers label Jan 27, 2024
@TheAfroOfDoom TheAfroOfDoom pinned this issue Jan 27, 2024
@TheAfroOfDoom TheAfroOfDoom added the chore stuff like code refactoring label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore stuff like code refactoring datapack Issues pertaining to the datapack enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant