Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cielo-Raymundo #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Cielo-Raymundo #9

wants to merge 2 commits into from

Conversation

CieloRaymundo
Copy link

No description provided.

@ROgbonna1
Copy link
Collaborator

Hey Cielo!
The styling of your form is nice. Great use of <li>s to align your grouped checkboxes and radio inputs.

One change request:
You did not label each input for your radios and checkboxes. Instead, you just labeled the heading. Each checkbox and radio input should have a label. What you labeled should instead be a <legend> for a <fieldset>.

Make these changes, push them back up, and I'll merge this PR in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CieloRaymundo @ROgbonna1