completed lab #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROgbonna1
reviewed
Oct 1, 2019
| <input id="name" type="text" value="" name="name"> | ||
| </div> | ||
|
|
||
| <div style="float:left;"> |
There was a problem hiding this comment.
Gotta get rid of this.
- No reason to have inline styling here.
- No use of floats for layout.
ROgbonna1
reviewed
Oct 1, 2019
|
|
||
| </section> | ||
|
|
||
| <section class="q4"> |
There was a problem hiding this comment.
You're using <section>s for grouping and <div>s for headers. I want you to use <fieldset>s and <legend>s instead.
ROgbonna1
reviewed
Oct 1, 2019
|
|
||
| </section> | ||
| <section class="q5"> | ||
| <text style="display:block;">This my last question. Whats your sign ?</text> |
There was a problem hiding this comment.
Get rid of this inline styling here.
ROgbonna1
reviewed
Oct 1, 2019
| <h4> Name this anime;<p>This anime is about some dude forcing a kid to eat his hair.</p></h4> | ||
|
|
||
| </div> | ||
| <input type="radio" name="" value="always">Made In Abyss |
There was a problem hiding this comment.
Each of these radio inputs needs a label. Example...
<input type="radio" name="anime" value="abyss" id="abyss">
<label for="abyss">Made In Abyss</label>Having appropriate values for name and value are super important here.
|
You got some work to do here, Peter. But forms are so important that it is worth it. Make these changes and push back up ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.