quiz your friend #5
Conversation
| <input type="checkbox" name="game-day" value="Sunday" id="game-day" checked>Sunday | ||
| <input type="checkbox" name="game-day" value="Monday" id="game-day">Monday | ||
| <input type="checkbox" name="game-day" value="Tuesday" id="game-day">Tuesday | ||
| <input type="checkbox" name="game-day" value="Wednesday" id="game-day">Wednesday | ||
| <input type="checkbox" name="game-day" value="Thursday" id="game-day">Thursday | ||
| <input type="checkbox" name="game-day" value="Friday" id="game-day">Friday | ||
| <input type="checkbox" name="game-day" value="Saturday" id="game-day">Saturday |
There was a problem hiding this comment.
You know, Paul, that each id should be unique. Your instincts are right here. ids would be nice here because we could associate our <input>s with our <label>s but here's how you implement it:
<input type="checkbox" name="game-day" value="Sunday" id="sunday">
<label for="sunday">Sunday</label>In sum, your for attribute on your <label> tag should match the id on your <input>. And most importantly, each one of these checkboxes needs its own label.
| <input type="radio" name="game-system" value="PS4">PS4 | ||
| <input type="radio" name="game-system" value="Xbox">Xbox | ||
| <input type="radio" name="game-system" value="Switch">Nintendo Switch |
There was a problem hiding this comment.
Same. Label all of these radios. Get rid of the <label> on the section title and instead use a <legend>.
| <fieldset class="game-name"> | ||
| <ul> | ||
| <li> | ||
| <label for ="game">1: What is your fav COD?</label> |
There was a problem hiding this comment.
The for attribute on your <label> should match the id for your <input>, not the name attribute.
|
You've got some changes to make here. Go ahead and make them and push them back up. Once this is perfect. I'll merge the PR. |
No description provided.