enmanuel-delanuez submission #6

julian-carvajal-gh · 2019-10-21T14:41:38Z

Cannot auto merge I think because in my process of renaming the files I told git to also erase the originals

ROgbonna1

Great work here, Enmanuel. Your communication is so clear. There are a couple of changes to be made. They shouldn't take long. Overall, though, great submission! 🚀

ROgbonna1 · 2019-10-23T05:53:23Z

enmanuel-delanuez/exercises/answers.js

@@ -0,0 +1,53 @@
+// Question 1: Looping a Triange
+function triangle() {


ROgbonna1 · 2019-10-23T05:54:46Z

enmanuel-delanuez/exercises/answers.js

+      console.log('FizzBuzz');
+    } else if (i % 3 == 0) {
+      console.log('Fizz');
+    } else if (i % 5 == 0 && i % 3 != 0) {


this check for i % 3 != 0 is redundant here. If i % 3 == 0 it would have evaluated to true on line 16, line 17 would have run and the conditional would have returned.

ROgbonna1 · 2019-10-23T05:55:58Z

enmanuel-delanuez/exercises/answers.js

+
+// Question 2: FizzBuzz
+function fizzBuzz() {
+  for (let i = 1; i <= 100; i++) {


You're using non-strict equality here (== instead of ===). Since you're dealing with numbers only, it shouldn't be an issue but it is still good practice to always use strict equality comparisons

ROgbonna1 · 2019-10-23T05:57:07Z

enmanuel-delanuez/exercises/answers.js

+}
+
+// Question 3: Chess Board
+function chessBoard() {


I love this. It's so clean. The variables and parameters are so well designed. Good work!

ROgbonna1 · 2019-10-23T05:59:01Z

enmanuel-delanuez/short-response.md

+# Problem Set 2.2 - Variables and Control Flow
+## Short Response Questions
+
+1. **What does the code below log? Why?**


You got rid of the brackets from the original version but I want them in there. This is what the question originally looked like:

{ let singer = 'Omar Apollo'; } console.log(`My favorite singer is ${singer});

Those brackets are important for this question.

ROgbonna1 · 2019-10-23T06:00:21Z

enmanuel-delanuez/short-response.md

+   favorite = 'Maya';
+   console.log(`Actually, ${favorite} is my favorite.`);
+   ```
+   This logs `'Our favorite Marcy Lab family member is Juan Pablo'` because the binding `favorite` was declared with the keyword `const`, meaning it is a constant that can't be reassigned.


Yes it logs this and...
Run this in the console and see what happens after the first statement is logged. Report back with what and why.

ROgbonna1 · 2019-10-23T06:00:40Z

enmanuel-delanuez/short-response.md

+   score = 100; 
+   console.log(score, newScore);
+   ```
+   This logs `100, 90` because line 1 declares `score` to be equals to `90`, line 2 declares `newScore` to be equal to `score`, line 3 reassigns `score` to be equal to `100`. When `console.log` runs, it reads `score` which was last reassigned to `100` and then reads `newScore` which still holds the value `90` because when it was declared it grasped the value of `score` and does not keep tracking any future changes to `score`.


ROgbonna1 · 2019-10-23T06:00:59Z

enmanuel-delanuez/short-response.md

+   let scream = greet;
+   console.log(scream); 
+   ```
+   This code doesnt log an uppercase string because while `scream` was declared and assigned `greet` after the `.toUpperCase` method, `greet` was acted upon but not *reassigned* to be the result of the operation. In order for us to see a log that is an uppercase string we can change our code to properly reassign the value of `greet`.


ROgbonna1 · 2019-10-23T06:01:35Z

enmanuel-delanuez/short-response.md

+
+   busy ? console.log(`${busy} evaluates to true`) : console.log(`${busy} evaluates to false.`);
+   ```
+   This will log `'ghost evaluates to true'` and `'null evaluates to false'`. This results from the use of the ternary operator to create a conditional. `someName` is declared as `name` OR `nickname`, using the bindings as the operands of a OR binary bitwise operator which returns the truthy `‘ghost’`. `busy` is declared as `children` AND `homework`, `null && ‘lots’`, returns null. The format of a conditonal program using a ternary operator looks like conditional ? expressionOne: expressionTwo; 


Great explanation

ROgbonna1 · 2019-10-23T06:01:45Z

enmanuel-delanuez/short-response.md

+     counter += 1;
+   }
+   ```
+   This loop is infinite because the binding `counter` is reassigned to a value that will ensure the conditional after `while` is true every time the loop is executed.


ROgbonna1

Great revisions, Enmanuel! 🙏🏿

ROgbonna1 · 2019-11-03T19:06:47Z

enmanuel-delanuez/exercises/answers.js

      console.log('Fizz');
-    } else if (i % 5 == 0 && i % 3 != 0) {
+    } else if (i % 5 === 0) {


Great changes to this question 👍

ROgbonna1 · 2019-11-03T19:07:05Z

enmanuel-delanuez/short-response.md

      console.log(`My favorite singer is ${singer}`);
   ```
-   This logs `'My favorite singer is Omar Apollo'` because the use of `${}` interpolates the value of a binding into the string.
+   This logs `ReferenceError: singer is not defined` because `console.log()` is looking for the variable `singer` in its global scope and cannot see it because it has a block scope. This is also supported by the keyword `let`, whereas the keyword `var` has a global or function scope.


That's it! Perfect answer!

ROgbonna1 · 2019-11-03T19:07:22Z

enmanuel-delanuez/short-response.md

@@ -16,7 +18,7 @@
   favorite = 'Maya';
   console.log(`Actually, ${favorite} is my favorite.`);
   ```
-   This logs `'Our favorite Marcy Lab family member is Juan Pablo'` because the binding `favorite` was declared with the keyword `const`, meaning it is a constant that can't be reassigned.
+   This logs `'Our favorite Marcy Lab family member is Juan Pablo'`. After, it logs a `TypeError` because the binding `favorite` was declared with the keyword `const` and we tried to reassign it before the second log which is not allowed.


Perfect! Great revision.

Enmanuel de la Nuez added 5 commits October 18, 2019 14:45

initial commit, rename submission dir

5ef321e

complete short resposes

d2ec262

add code for triangle fn

ba61034

write triangle and fizzbuzz functions

b3abc27

add chessBoard function

a5e7ef0

ROgbonna1 requested changes Oct 23, 2019

View reviewed changes

Enmanuel de la Nuez added 2 commits October 23, 2019 17:44

modify functions based on PR feedback

575b377

modify short-responses based on PR feedback

1d8e715

ROgbonna1 approved these changes Nov 3, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enmanuel-delanuez submission #6

enmanuel-delanuez submission #6

julian-carvajal-gh commented Oct 21, 2019

ROgbonna1 left a comment

ROgbonna1 Oct 23, 2019

ROgbonna1 Oct 23, 2019

ROgbonna1 Oct 23, 2019

ROgbonna1 Oct 23, 2019

ROgbonna1 Oct 23, 2019

ROgbonna1 Oct 23, 2019

ROgbonna1 Oct 23, 2019

ROgbonna1 Oct 23, 2019

ROgbonna1 Oct 23, 2019

ROgbonna1 Oct 23, 2019

ROgbonna1 left a comment

ROgbonna1 Nov 3, 2019

ROgbonna1 Nov 3, 2019

ROgbonna1 Nov 3, 2019

		@@ -0,0 +1,53 @@
		// Question 1: Looping a Triange
		function triangle() {

enmanuel-delanuez submission #6

Are you sure you want to change the base?

enmanuel-delanuez submission #6

Conversation

julian-carvajal-gh commented Oct 21, 2019

ROgbonna1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ROgbonna1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment