feat(core): connect all existing configs with manager

ThatOpen · Aug 31, 2024 · fde9faa · fde9faa
1 parent e62f783
commit fde9faa
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 2 deletions.
diff --git a/packages/core/src/core/Clipper/index.ts b/packages/core/src/core/Clipper/index.ts
@@ -13,6 +13,7 @@ import { Components } from "../Components";
 import { Raycasters } from "../Raycasters";
 import { Worlds } from "../Worlds";
 import { ClipperConfig, ClipperConfigManager } from "./src/clipper-config";
+import { ConfigManager } from "../ConfigManager";
 
 export * from "./src";
 
@@ -186,11 +187,18 @@ export class Clipper
   constructor(components: Components) {
     super(components);
     this.components.add(Clipper.uuid, this);
+
+    const configs = components.get(ConfigManager);
+    configs.list.add(this.config);
   }
 
   /** {@link Disposable.dispose} */
   dispose() {
     this._enabled = false;
+
+    const configs = this.components.get(ConfigManager);
+    configs.list.delete(this.config);
+
     for (const plane of this.list) {
       plane.dispose();
     }

diff --git a/packages/core/src/core/ConfigManager/index.ts b/packages/core/src/core/ConfigManager/index.ts
@@ -1,4 +1,4 @@
-import { Component } from "../Types";
+import { Component, DataSet } from "../Types";
 import { Components } from "../Components";
 import { Configurator } from "./src";
 
@@ -8,7 +8,10 @@ export * from "./src";
  * A tool to manage all the configuration from the app centrally.
  */
 export class ConfigManager extends Component {
-  list = new Set<Configurator<any, any>>();
+  /**
+   * The list of all configurations of this app.
+   */
+  list = new DataSet<Configurator<any, any>>();
 
   /** {@link Component.enabled} */
   enabled = true;

diff --git a/packages/core/src/core/Cullers/src/culler-renderer.ts b/packages/core/src/core/Cullers/src/culler-renderer.ts
@@ -6,6 +6,7 @@ import {
   CullerRendererConfig,
   CullerRendererConfigManager,
 } from "./culler-renderer-config";
+import { ConfigManager } from "../../ConfigManager";
 
 /**
  * A base renderer to determine visibility on screen.
@@ -102,6 +103,9 @@ export class CullerRenderer
       "Culler renderer",
     );
 
+    const configs = this.components.get(ConfigManager);
+    configs.list.add(this.config);
+
     this.world = world;
     this.renderer = new THREE.WebGLRenderer();
 
@@ -136,6 +140,10 @@ export class CullerRenderer
   dispose() {
     this.enabled = false;
     this.config.autoUpdate = false;
+
+    const configs = this.components.get(ConfigManager);
+    configs.list.delete(this.config);
+
     for (const child of this.scene.children) {
       child.removeFromParent();
     }

diff --git a/packages/core/src/core/Worlds/src/simple-scene.ts b/packages/core/src/core/Worlds/src/simple-scene.ts
@@ -5,6 +5,7 @@ import {
   SimpleSceneConfig,
   SimpleSceneConfigManager,
 } from "./simple-scene-config";
+import { ConfigManager } from "../../ConfigManager";
 
 /**
  * A basic 3D [scene](https://threejs.org/docs/#api/en/scenes/Scene) to add objects hierarchically, and easily dispose them when you are finished with it.
@@ -45,6 +46,9 @@ export class SimpleScene
     super(components);
     this.three = new THREE.Scene();
     this.three.background = new THREE.Color(0x202932);
+
+    const configs = this.components.get(ConfigManager);
+    configs.list.add(this.config);
   }
 
   /** {@link Configurable.setup} */
@@ -78,4 +82,10 @@ export class SimpleScene
     this.isSetup = true;
     this.onSetup.trigger();
   }
+
+  dispose() {
+    super.dispose();
+    const configs = this.components.get(ConfigManager);
+    configs.list.delete(this.config);
+  }
 }