fix(core): add guard when getting all properties

ThatOpen · Aug 28, 2024 · 3048618 · 3048618
1 parent 1570899
commit 3048618
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@thatopen/components",
   "description": "Collection of core functionalities to author BIM apps.",
-  "version": "2.3.0-alpha.2",
+  "version": "2.3.0-alpha.3",
   "author": "That Open Company",
   "contributors": [
     "Antonio Gonzalez Viegas (https://github.com/agviegas)",

diff --git a/packages/core/src/ifc/IfcJsonExporter/index.ts b/packages/core/src/ifc/IfcJsonExporter/index.ts
@@ -68,8 +68,14 @@ export class IfcJsonExporter extends Component {
 
       // const allIDs = this._webIfc.GetAllLines(0);
       for (const id of ids) {
-        const property = webIfc.GetLine(0, id, recursive, indirect);
-        properties[property.expressID] = property;
+        try {
+          const property = webIfc.GetLine(0, id, recursive, indirect);
+          properties[property.expressID] = property;
+        } catch (e) {
+          console.log(
+            `Could not get property ${id}, with recursive ${recursive} and indirect ${indirect}.`,
+          );
+        }
       }
     }
 

diff --git a/packages/front/package.json b/packages/front/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@thatopen/components-front",
   "description": "Collection of frontend tools to author BIM apps.",
-  "version": "2.3.0-alpha.4",
+  "version": "2.3.0-alpha.5",
   "author": "That Open Company",
   "contributors": [
     "Antonio Gonzalez Viegas (https://github.com/agviegas)",
@@ -38,7 +38,7 @@
     "web-ifc": "0.0.57"
   },
   "devDependencies": {
-    "@thatopen/fragments": "2.3.0-alpha.1",
+    "@thatopen/fragments": ">=2.3.0-alpha",
     "@thatopen/ui": "~2.2.0",
     "@thatopen/ui-obc": "~2.2.0",
     "@types/earcut": "^2.1.4",
@@ -47,7 +47,7 @@
     "web-ifc": "0.0.57"
   },
   "dependencies": {
-    "@thatopen/components": "2.3.0-alpha.1",
+    "@thatopen/components": ">=2.3.0-alpha",
     "camera-controls": "2.7.3",
     "dexie": "^4.0.4",
     "earcut": "^2.2.4",