fix: force context release when disposing renderers

ThatOpen · Aug 12, 2024 · 11e0860 · 11e0860
1 parent 67b08df
commit 11e0860
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 3 deletions.
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@thatopen/components",
   "description": "Collection of core functionalities to author BIM apps.",
-  "version": "2.1.23",
+  "version": "2.1.24",
   "author": "That Open Company",
   "contributors": [
     "Antonio Gonzalez Viegas (https://github.com/agviegas)",

diff --git a/packages/core/src/core/Components/index.ts b/packages/core/src/core/Components/index.ts
@@ -14,7 +14,7 @@ export class Components implements Disposable {
   /**
    * The version of the @thatopen/components library.
    */
-  static readonly release = "2.1.23";
+  static readonly release = "2.1.24";
 
   /** {@link Disposable.onDisposed} */
   readonly onDisposed = new Event<void>();

diff --git a/packages/core/src/core/Cullers/src/culler-renderer.ts b/packages/core/src/core/Cullers/src/culler-renderer.ts
@@ -147,6 +147,7 @@ export class CullerRenderer {
     }
     this.onViewUpdated.reset();
     this.worker.terminate();
+    this.renderer.forceContextLoss();
     this.renderer.dispose();
     this.renderTarget.dispose();
     (this._buffer as any) = null;

diff --git a/packages/core/src/core/MiniMap/src/index.ts b/packages/core/src/core/MiniMap/src/index.ts
@@ -139,6 +139,7 @@ export class MiniMap implements Resizeable, Updateable, Disposable {
     this.onAfterUpdate.reset();
     this.onResize.reset();
     this.overrideMaterial.dispose();
+    this.renderer.forceContextLoss();
     this.renderer.dispose();
     this.onDisposed.trigger();
     this.onDisposed.reset();

diff --git a/packages/core/src/core/ShadowedScene/src/distance-renderer.ts b/packages/core/src/core/ShadowedScene/src/distance-renderer.ts
@@ -181,6 +181,7 @@ void main() {
     this.enabled = false;
     this.onDistanceComputed.reset();
     this.worker.terminate();
+    this.renderer.forceContextLoss();
     this.renderer.dispose();
     this.tempRT.dispose();
     this.resultRT.dispose();

diff --git a/packages/core/src/core/Worlds/src/simple-renderer.ts b/packages/core/src/core/Worlds/src/simple-renderer.ts
@@ -90,6 +90,7 @@ export class SimpleRenderer extends BaseRenderer {
     this.enabled = false;
     this.setupEvents(false);
     this.three.domElement.remove();
+    this.three.forceContextLoss();
     this.three.dispose();
     // this._renderer2D.domElement.remove();
     this.onResize.reset();

diff --git a/packages/front/package.json b/packages/front/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@thatopen/components-front",
   "description": "Collection of frontend tools to author BIM apps.",
-  "version": "2.1.25",
+  "version": "2.1.26",
   "author": "That Open Company",
   "contributors": [
     "Antonio Gonzalez Viegas (https://github.com/agviegas)",

diff --git a/packages/front/src/core/PostproductionRenderer/src/postproduction.ts b/packages/front/src/core/PostproductionRenderer/src/postproduction.ts
@@ -161,6 +161,7 @@ export class Postproduction {
    * It releases the memory occupied by the render target, depth texture, custom effects pass, gamma pass, and N8AO pass.
    */
   dispose() {
+    this.composer.dispose();
     this._renderTarget.dispose();
     this._depthTexture?.dispose();
     this._customEffects?.dispose();