Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/registration check in #1405

Merged
merged 5 commits into from
Jun 30, 2023
Merged

Refactor/registration check in #1405

merged 5 commits into from
Jun 30, 2023

Conversation

brettski
Copy link
Collaborator

v3.10.0

Fixed:

  • Unable to interact with modal in order view
  • new pin remains on ticket after re-sorting
  • tickets marked dirty until data is refreshed
  • variable name typo checkInErroMessage
  • filtered collection doesn't change until minMatchCharLength is reached
  • footer going over update modal

@brettski brettski added the bug Something isn't working label Jun 30, 2023
@brettski brettski self-assigned this Jun 30, 2023
@vercel
Copy link

vercel bot commented Jun 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
that.us ✅ Ready (Inspect) Visit Preview Jun 30, 2023 6:12pm

theClarkSell
theClarkSell previously approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@theClarkSell theClarkSell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review it but send it

@brettski brettski marked this pull request as ready for review June 30, 2023 18:15
@brettski brettski changed the base branch from master to next/feature June 30, 2023 18:16
@brettski brettski dismissed theClarkSell’s stale review June 30, 2023 18:16

The base branch was changed.

@brettski brettski merged commit 7fd518e into next/feature Jun 30, 2023
4 checks passed
@brettski brettski deleted the refactor/registration-check-in branch June 30, 2023 18:39
@brettski brettski mentioned this pull request Jun 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theClarkSell theClarkSell theClarkSell approved these changes

Assignees

@brettski brettski

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brettski @theClarkSell