Fixes, and rework anti-GC dict #11
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dragorn421
commented
Dec 23, 2022
pygfxd.py
Outdated
Comment on lines
392
to
420
| cb = CFUNCTYPE(c_int, c_void_p, c_int)(fn) | ||
| __gfxd_buffers_callbacks.update({102 : cb}) | ||
| lgfxd.gfxd_input_callback(cb) | ||
| if fn is not None: | ||
| cb = CFUNCTYPE(c_int, c_void_p, c_int)(fn) | ||
| __gfxd_buffers_callbacks[gfxd_input_callback] = cb | ||
| lgfxd.gfxd_input_callback(cb) | ||
| else: | ||
| lgfxd.gfxd_input_callback(CFUNCTYPE(c_int, c_void_p, c_int)()) | ||
| del __gfxd_buffers_callbacks[gfxd_input_callback] |
There was a problem hiding this comment.
Typically, is this looking good to you?
Dragorn421
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gfxd_arg_fntakesint fn(void)but libgfxd expectsvoid fn(int)#10gfxd_arg_value,gfxd_value_by_typebindings when libgfxd returns NULL, and improve how it works tooThe first point is WIP, will un-draft when it's done.
Before proceeding though, I'd like to know if I should carry on or change some things. So, any opinions?
This passes my wip tests from #7 (or at least it passes them now that the tests made me notice an issue pepeLaugh)