-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arabian Text Trait Bug Fix #194
Conversation
The Text for the Arabian trait is called "TXT_KEY_TRAIT_LAND_TRADE_GOLD2" while CEP uses the same thing without the '2' This minor fix points the variables of Description and ShortDescription to the CEP text instead of the vanilla text.
@EricB1, you should just work directly on the project now that @Thalassicus has made you a project collaborator. |
You can also merge this pull yourself. Did you modify the google spreadsheet to reflect this text change? |
I saw that I had been added as a project collaborator, but I didn't want to put through a change without input from others. This change is really just a bug fix and doesn't alter the design of the project. Do those types of changes need to go into the spreadsheet? |
I also sent a request to get access to the google docs spreadsheet. It was blocking me. |
Follow the instructions here to join the group: #6 (comment) |
I misread your commit message. Did you update the policy text in the spreadsheets? And the tech path? I believe you modified both in previous merges. |
And there shouldn't be a problem with bug fixing like this and @Thalassicus has given you project permissions. |
Okay I updated the spreadsheet for the policy changes and also for the tech prereq change. I didn't update anything for the small bug fix to Arabia as there's no spreadsheet data for something like that. |
Yeah, I thought the error was in the text itself instead of the name. |
Shouldn't a bugfix like this be added to the stable branch? |
The Text for the Arabian trait is called
"TXT_KEY_TRAIT_LAND_TRADE_GOLD2" while CEP uses the same thing without
the '2'
This minor fix points the variables of Description and ShortDescription
to the CEP text instead of the vanilla text.