Customisable seek duration #391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThaUnknown
force-pushed
the
master
branch
2 times, most recently
from
c684a2b to
6a5347d
Compare
ThaUnknown
force-pushed
the
master
branch
3 times, most recently
from
9f745cf to
fc8bab6
Compare
ThaUnknown
force-pushed
the
master
branch
3 times, most recently
from
d00d0c4 to
25ba650
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! So I noticed you could only seek +-2s with arrow keys which is tedious when you need to find that one specific part of the episode in the middle. So I defaulted the seek duration to 2s, but now its in Playback settings in case you need to increase (or decrease it)
I also reload the keybinds everytime since I wanted to show how much it seeks when you open the settings as soon as you press the hotkey (`) or click the button since I cant figure out a more efficient way of hot reloading that part, but I dont think that matters too much with performance since it should consume negligible resources to reload hotkeys, when comparing to the entire app.
Thanks for this app, has to be my favourite apps in a while ❤️