-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alex GitHub Action Build, Upload and Comment #71
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting up Github Actions by adding main.yml with two stages - build and unit tests
…setup-deno step working
…n that run ID is available in upload context job
…queria into alex-github-action-pr-update
Deploying with
|
Latest commit: |
17cb897
|
Status: | ✅ Deploy successful! |
Preview URL: | https://497a7a28.taqueria.pages.dev |
GImbrailo
reviewed
Jan 12, 2022
GImbrailo
reviewed
Jan 12, 2022
… use a relative path for the upload
GImbrailo
approved these changes
Jan 12, 2022
sinapsist
added a commit
that referenced
this pull request
Jan 18, 2022
* Setting up Github Actions Setting up Github Actions by adding main.yml with two stages - build and unit tests * checking out the github actions yaml file format and trying to get a setup-deno step working * removed old ID that I was keeping for posterity * checking deno fmt command * added my branch to github actions to make the actions run on push * removing formatting, is no bueno * turning off linter to see tests in action * added step to build taqueria * added part of action to check the taqueria version * added separate step for checking version * added step to try and build taqueria SDK * moved directory navigation to before setting up node * dummy package.json from sdk folder to get past node installation error * including package-lock.json file * trying protocol instead of sdk directories * changing wording in step names to protocol * trying out SDK build again * added in build step after deps install * adding steps for logging node and npm versions * trying to not use cache for node, seeing if this will change up the npm version * checking if deno is the problem with build system error for top level await * added deno setup for build steps * indentation problem * adding build step for all taqueria to see if it makes hidden things available * adding deno setup to builds * changing ubuntu runner version to see if it makes a difference * seeing if changing commands will help by specifying output format * moving all steps for build into single step to make use of single working directory * moving commands to different run steps * making buid command a multi-line command * fixing indentation * removed dash * added step to upload taqueria binary * trying to use dynamic path in github actions for binary upload * changing back to hard coding directory right now until dynamic solution can be found * added section to look into github script for doing things in PRs * adding in comment section to PR * removing secrets token * downgraded version of github script * getting info for all context data * changing script to run for multiline to see if it works * going back to basics on context * now adding back in actual command for adding comment * adding github example to see if it works * adding in section to try and get all artifacts for a run * trying to get request to work * fixed indentation * updating github token for request to artifacts API endpoint * typo on run number for workflow * adding in step to get context info * adding step to gather needed info for repo * trying to get the result and use it in downstream steps * targetting specific info * adding step to use built in octokit API call for listing workflow artifacts * forgot work in command * incorrect case wasn't getting the run number * trying to get artiifacts for whole repo * trying to get output for both queries on atrifacts * changed name for getting context info * trying to target based on repo name and experiment with options * using repo.repo * changing step order * updating runNumber to runId * updated echo commands to use correct formatting * trying to get more results from github script steps * forgot quotes on the echo for results * trying with other access token * added sleep to see if artifacts will show up * commenting out listing artifacts from whole repo * splitting building and updating PR into separate jobs * added in needs clause for update jobs * added context log to both jobs * changing github token to test token to try personal access token for getting artifacts * adding separate file for other workflow to trigger off successful build workflow * removed branch requirement from secondary workflow * changed types to list * added in requested type for workflow downstream run * removing types from other workflow * changing name of workflow to see if it shows up in github * removing branch specific information * added in main branch again * adding in Gino's part for the second URL building step and testing * wrong branch name and updated run ID * removing matrixed job for building to see if that affects workflow runs * added specific file for uploading taq binary * renamed PR update file * adding in if condition on PR update * adding in step to test out link generation * trying with current runID * getting runId from job and ensuring it is in the right output * changed around calling condition to make sure that upload workflow runs * removed starting conditions for unused workflow files and changed targetting for upload job results * updated PR update job to use run ID from upload job * updated called workflow to use commit reference * trying to get dummy value through and updated casing typo in export for upload workflow * fixed renaming type * trying to get output from correct ID with correct variable name * updating commit hash for dependant workflow * adding in getting info job to see what is in the context * adding in runner for getting info job * making called workflow depend on getting info * updating called workflow to use branch name and adding in verification that run ID is available in upload context job * forgot to add run step for sleep command * added in step for checking the context result is showing correctly * added output for job in upload job * indentation error on checking final output * made retrieving the ID more concise * adding in step to get artifact * made changes to make taqueria yml files match testing versions for PR * removed main.yml for now since it is not used * Setting up Github Actions Setting up Github Actions by adding main.yml with two stages - build and unit tests * checking out the github actions yaml file format and trying to get a setup-deno step working * removed old ID that I was keeping for posterity * checking deno fmt command * added my branch to github actions to make the actions run on push * removing formatting, is no bueno * turning off linter to see tests in action * added step to build taqueria * added part of action to check the taqueria version * added separate step for checking version * added step to try and build taqueria SDK * moved directory navigation to before setting up node * dummy package.json from sdk folder to get past node installation error * including package-lock.json file * trying protocol instead of sdk directories * changing wording in step names to protocol * trying out SDK build again * added in build step after deps install * adding steps for logging node and npm versions * trying to not use cache for node, seeing if this will change up the npm version * checking if deno is the problem with build system error for top level await * added deno setup for build steps * indentation problem * adding build step for all taqueria to see if it makes hidden things available * adding deno setup to builds * changing ubuntu runner version to see if it makes a difference * seeing if changing commands will help by specifying output format * moving all steps for build into single step to make use of single working directory * moving commands to different run steps * making buid command a multi-line command * fixing indentation * removed dash * added step to upload taqueria binary * trying to use dynamic path in github actions for binary upload * changing back to hard coding directory right now until dynamic solution can be found * added section to look into github script for doing things in PRs * adding in comment section to PR * removing secrets token * downgraded version of github script * getting info for all context data * changing script to run for multiline to see if it works * going back to basics on context * now adding back in actual command for adding comment * adding github example to see if it works * adding in section to try and get all artifacts for a run * trying to get request to work * fixed indentation * updating github token for request to artifacts API endpoint * typo on run number for workflow * adding in step to get context info * adding step to gather needed info for repo * trying to get the result and use it in downstream steps * targetting specific info * adding step to use built in octokit API call for listing workflow artifacts * forgot work in command * incorrect case wasn't getting the run number * trying to get artiifacts for whole repo * trying to get output for both queries on atrifacts * changed name for getting context info * trying to target based on repo name and experiment with options * using repo.repo * changing step order * updating runNumber to runId * updated echo commands to use correct formatting * trying to get more results from github script steps * forgot quotes on the echo for results * trying with other access token * added sleep to see if artifacts will show up * commenting out listing artifacts from whole repo * splitting building and updating PR into separate jobs * added in needs clause for update jobs * added context log to both jobs * changing github token to test token to try personal access token for getting artifacts * adding separate file for other workflow to trigger off successful build workflow * removed branch requirement from secondary workflow * changed types to list * added in requested type for workflow downstream run * removing types from other workflow * changing name of workflow to see if it shows up in github * removing branch specific information * added in main branch again * adding in Gino's part for the second URL building step and testing * wrong branch name and updated run ID * removing matrixed job for building to see if that affects workflow runs * added specific file for uploading taq binary * renamed PR update file * adding in if condition on PR update * adding in step to test out link generation * trying with current runID * getting runId from job and ensuring it is in the right output * changed around calling condition to make sure that upload workflow runs * removed starting conditions for unused workflow files and changed targetting for upload job results * updated PR update job to use run ID from upload job * updated called workflow to use commit reference * trying to get dummy value through and updated casing typo in export for upload workflow * fixed renaming type * trying to get output from correct ID with correct variable name * updating commit hash for dependant workflow * adding in getting info job to see what is in the context * adding in runner for getting info job * making called workflow depend on getting info * updating called workflow to use branch name and adding in verification that run ID is available in upload context job * forgot to add run step for sleep command * added in step for checking the context result is showing correctly * added output for job in upload job * indentation error on checking final output * made retrieving the ID more concise * adding in step to get artifact * made changes to make taqueria yml files match testing versions for PR * removed main.yml for now since it is not used * removing dummy package.json files * updating upload workflow to only run on PRs to the main branch and to use a relative path for the upload Co-authored-by: sinapsist <sinapsist@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR encompasses the following: