✨ Feature ➾ Add .gitignore file upon taq init
#1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchenche
changed the title
.gitignore file upon taq init
|
LGTM |
mweichert
reviewed
Dec 7, 2022
| @@ -425,6 +430,7 @@ const initProject = ( | |||
| mkInitialDirectories(projectDir, maxConcurrency, i18n), | |||
| chain(_ => exec('npm init -y 2>&1 > /dev/null', {}, false, projectDir)), | |||
| chain(_ => exec('taq install @taqueria/plugin-core 2>&1 > /dev/null', {}, false, projectDir)), | |||
| map(_ => createGitIgnoreFile(projectDir)), | |||
There was a problem hiding this comment.
Shouldn't this be chain?
There was a problem hiding this comment.
No because createGitIgnoreFile is a function that returns a future
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌮 Taqueria PR
#Fixes #1461
🪁 Description
Add
.gitignorefile upon taq init.🪂 Pre-Merge Checklist (Definition of Done)
🚦 Required to merge:
🛩️ Summary of Changes
Please include a summary of the changes to the codebase. Please also include relevant motivation and context for the change
(e.g. what was the existing behaviour, why did it break, etc.)
🎢 Test Plan
Please describe the testing strategy and plan for this PR. Keep this lightweight and anticipate any testing challenges
🛸 Type of Change