Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open Contracts and Artifacts when double-clicking a TreeViewItem in Taqueria sidebar #1583

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Open Contracts and Artifacts when double-clicking a TreeViewItem in Taqueria sidebar #1583

merged 2 commits into from
Dec 7, 2022

Conversation

ac10n
Copy link
Contributor

@ac10n ac10n commented Dec 6, 2022 •
edited
Loading

🌮 Taqueria PR

🪁 Description

We can see the contracts and artifacts in the sidebar, but clicking on them did not open them in the editor.

🪂 Pre-Merge Checklist (Definition of Done)

🚦 Required to merge:

  • ⛱️ I have completed this PR template in full and updated the title appropriately
  • ⛵ My code builds cleanly, and I have manually tested the changes
  • 🏄‍♂️ Another team member has built this branch and done manual testing on the change
  • 🏖️ New and existing unit tests pass locally and in CI
  • 🔱 The test plan has been implemented and verified by an SDET
  • 🦀 Automated tests have been written and added to this PR
  • 🐬 I have commented my code, particularly in hard-to-understand areas
  • 🤿 Corresponding changes have been made to all documentation
  • 🐚 Required changes to the VScE have been made
  • 🪸 Required updates to scaffolds have been made
  • 🚢 The release checklist has been completed

🛩️ Summary of Changes

Now clicking on contracts and artifacts in the sidebar opens them in the text editor

🎢 Test Plan

Please describe the testing strategy and plan for this PR. Keep this lightweight and anticipate any testing challenges

🛸 Type of Change

  • 🧽 Chore ➾
  • 🛠️ Fix ➾
  • ✨ Feature ➾
  • 👷 Refactor ➾
  • 🧪 Pre-Release ➾
  • 🚀 Release ➾

ac10n and others added 2 commits December 6, 2022 11:54
@ac10n
Open contracts and artifacts On TreeItem's Double-Click
af864dc
@MichalLytek @ac10n
🛠️ Fix ➾ Prevent running compile current file command if the text edi…
36b552c 
…tor is not focused (#1573)

* Add guard for running taq compile on unfocused text editor

* Add condition to enablement to hide command in pallette
@ac10n ac10n changed the base branch from main to prerelease-0.25.0 December 6, 2022 19:59
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 36b552c
Status: ✅  Deploy successful!
Preview URL: https://29879c36.taqueria.pages.dev
Branch Preview URL: https://1075-improvements-to-tvsce-2.taqueria.pages.dev

View logs

@ac10n ac10n marked this pull request as ready for review December 6, 2022 19:59
@ac10n ac10n requested review from a team and removed request for a team December 6, 2022 19:59
egarson
egarson approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@egarson egarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ac10n ac10n merged commit 17c36ba into prerelease-0.25.0 Dec 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2022
@ac10n ac10n deleted the 1075-improvements-to-TVsCE-2 branch December 8, 2022 00:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@egarson egarson egarson approved these changes

@jchenche jchenche jchenche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ac10n @egarson @jchenche @MichalLytek