Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧽 Chore ➾ Delete legacy lerna bootstrap commands #1567

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

danielelisi
Copy link
Contributor

@danielelisi danielelisi commented Nov 30, 2022

🌮 Taqueria PR

🪁 Description

lerna bootstrap is a legacy command that was used to install and link all dependencies for packages in a monorepo.

[Lerna docs suggest to stop using lerna bootstrap](https://lerna.js.org/docs/features/legacy-package-management#background) and instead let the package manager handle this task as now it's handled by NPM Workspaces when running npm ci and npm install.

This PR removes all references of lerna bootstrap in the codebase

🪂 Pre-Merge Checklist (Definition of Done)

🚦 Required to merge:

  • ⛱️ I have completed this PR template in full and updated the title appropriately
  • ⛵ My code builds cleanly, and I have manually tested the changes
  • 🏄‍♂️ Another team member has built this branch and done manual testing on the change
  • 🏖️ New and existing unit tests pass locally and in CI
  • 🔱 The test plan has been implemented and verified by an SDET
  • 🦀 Automated tests have been written and added to this PR
  • 🐬 I have commented my code, particularly in hard-to-understand areas
  • 🤿 Corresponding changes have been made to all documentation
  • 🐚 Required changes to the VScE have been made
  • 🪸 Required updates to scaffolds have been made
  • 🚢 The release checklist has been completed

🛩️ Summary of Changes

This PR removes all references of lerna bootstrap in the codebase

🎢 Test Plan

  • Searched trough the repo for lerna bootstrap and removed its occurrences.
  • All CI workflows pass

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 30, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7434225
Status: ✅  Deploy successful!
Preview URL: https://2152175d.taqueria.pages.dev
Branch Preview URL: https://remove-legacy-lerna-bootstra.taqueria.pages.dev

View logs

@github-actions
Copy link
Contributor

Latest Commit 7434225
Taq Binaries

Linux
MacOS
Windows

npm Packages

npm i @taqueria/plugin-archetype@0.22.2-1567.74342252 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-contract-types@0.22.2-1567.74342252 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-core@0.22.2-1567.74342252 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-flextesa@0.22.2-1567.74342252 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-ipfs-pinata@0.22.2-1567.74342252 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-jest@0.22.2-1567.74342252 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-ligo@0.22.2-1567.74342252 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-metadata@0.22.2-1567.74342252 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-smartpy@0.22.2-1567.74342252 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-taquito@0.22.2-1567.74342252 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-tezos-client@0.22.2-1567.74342252 --registry https://npm.ecadinfra.com
npm i @taqueria/protocol@0.22.2-1567.74342252 --registry https://npm.ecadinfra.com
npm i @taqueria/node-sdk@0.22.2-1567.74342252 --registry https://npm.ecadinfra.com
npm i @taqueria/state@0.22.2-1567.74342252 --registry https://npm.ecadinfra.com
npm i @taqueria/toolkit@0.22.2-1567.74342252 --registry https://npm.ecadinfra.com
npm i @0.22.2-1567.74342252 --registry https://npm.ecadinfra.com

VSCode Extension VSIX

taqueria-vscode-remove_legacy_lerna_bootstrap-ubuntu-latest

@danielelisi danielelisi marked this pull request as ready for review November 30, 2022 03:21
@danielelisi danielelisi requested a review from a team as a code owner November 30, 2022 03:21
@danielelisi danielelisi requested a review from a team November 30, 2022 03:21
@danielelisi danielelisi self-assigned this Nov 30, 2022
@danielelisi danielelisi merged commit 791156e into main Nov 30, 2022
@danielelisi danielelisi deleted the remove_legacy_lerna_bootstrap branch November 30, 2022 17:21
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants