Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log scaffold.json contents when scaffolding #1545

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

mweichert
Copy link
Collaborator

🌮 Taqueria PR

🪁 Description

Removing left-over debugging statement, which outputs the contents of the scaffold.json file:

{
    "postInit": "npm run setup"
}

🪂 Pre-Merge Checklist (Definition of Done)

🚦 Required to merge:

  • ⛱️ I have completed this PR template in full and updated the title appropriately
  • ⛵ My code builds cleanly, and I have manually tested the changes
  • 🏄‍♂️ Another team member has built this branch and done manual testing on the change
  • 🏖️ New and existing unit tests pass locally and in CI
  • 🔱 The test plan has been implemented and verified by an SDET
  • 🦀 Automated tests have been written and added to this PR
  • 🐬 I have commented my code, particularly in hard-to-understand areas
  • 🤿 Corresponding changes have been made to all documentation
  • 🐚 Required changes to the VScE have been made
  • 🪸 Required updates to scaffolds have been made
  • 🚢 The release checklist has been completed

🛩️ Summary of Changes

Please include a summary of the changes to the codebase. Please also include relevant motivation and context for the change
(e.g. what was the existing behaviour, why did it break, etc.)

🎢 Test Plan

Please describe the testing strategy and plan for this PR. Keep this lightweight and anticipate any testing challenges

🛸 Type of Change

  • 🧽 Chore ➾
  • 🛠️ Fix ➾
  • ✨ Feature ➾
  • 👷 Refactor ➾
  • 🧪 Pre-Release ➾
  • 🚀 Release ➾

Removing left-over debugging statement.
@mweichert mweichert requested a review from a team November 24, 2022 00:47
@mweichert mweichert self-assigned this Nov 24, 2022
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 88a70ab
Status: ✅  Deploy successful!
Preview URL: https://33f65044.taqueria.pages.dev
Branch Preview URL: https://remove-debugging-statement-f.taqueria.pages.dev

View logs

@github-actions
Copy link
Contributor

Latest Commit 88a70ab
Taq Binaries

Linux
MacOS
Windows

npm Packages

npm i @taqueria/plugin-archetype@0.22.2-1545.88a70ab6 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-contract-types@0.22.2-1545.88a70ab6 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-core@0.22.2-1545.88a70ab6 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-flextesa@0.22.2-1545.88a70ab6 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-ipfs-pinata@0.22.2-1545.88a70ab6 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-jest@0.22.2-1545.88a70ab6 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-ligo@0.22.2-1545.88a70ab6 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-metadata@0.22.2-1545.88a70ab6 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-smartpy@0.22.2-1545.88a70ab6 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-taquito@0.22.2-1545.88a70ab6 --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-tezos-client@0.22.2-1545.88a70ab6 --registry https://npm.ecadinfra.com
npm i @taqueria/protocol@0.22.2-1545.88a70ab6 --registry https://npm.ecadinfra.com
npm i @taqueria/node-sdk@0.22.2-1545.88a70ab6 --registry https://npm.ecadinfra.com
npm i @taqueria/state@0.22.2-1545.88a70ab6 --registry https://npm.ecadinfra.com
npm i @taqueria/toolkit@0.22.2-1545.88a70ab6 --registry https://npm.ecadinfra.com
npm i @0.22.2-1545.88a70ab6 --registry https://npm.ecadinfra.com

VSCode Extension VSIX

taqueria-vscode-remove-debugging-statement-from-scaffold-task-ubuntu-latest

@mweichert mweichert merged commit 1f40c1f into main Nov 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants