Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to build process #1530

Merged
merged 9 commits into from
Nov 25, 2022
Merged

Fixes to build process #1530

merged 9 commits into from
Nov 25, 2022

Conversation

ac10n
Copy link
Contributor

@ac10n ac10n commented Nov 21, 2022

🌮 Taqueria PR

🪁 Description

Explain it to me like I'm 5! Keep this short and descriptive

🪂 Pre-Merge Checklist (Definition of Done)

🚦 Required to merge:

  • ⛱️ I have completed this PR template in full and updated the title appropriately
  • ⛵ My code builds cleanly, and I have manually tested the changes
  • 🏄‍♂️ Another team member has built this branch and done manual testing on the change
  • 🏖️ New and existing unit tests pass locally and in CI
  • 🔱 The test plan has been implemented and verified by an SDET
  • 🦀 Automated tests have been written and added to this PR
  • 🐬 I have commented my code, particularly in hard-to-understand areas
  • 🤿 Corresponding changes have been made to all documentation
  • 🐚 Required changes to the VScE have been made
  • 🪸 Required updates to scaffolds have been made
  • 🚢 The release checklist has been completed

🛩️ Summary of Changes

Please include a summary of the changes to the codebase. Please also include relevant motivation and context for the change
(e.g. what was the existing behaviour, why did it break, etc.)

🎢 Test Plan

Please describe the testing strategy and plan for this PR. Keep this lightweight and anticipate any testing challenges

🛸 Type of Change

  • 🧽 Chore ➾
  • 🛠️ Fix ➾
  • ✨ Feature ➾
  • 👷 Refactor ➾
  • 🧪 Pre-Release ➾
  • 🚀 Release ➾

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 21, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: bfd922a
Status: ✅  Deploy successful!
Preview URL: https://29d42a19.taqueria.pages.dev
Branch Preview URL: https://improvements-to-build-and-te.taqueria.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2022 •
edited
Loading

Latest Commit bfd922a
Taq Binaries

Linux
MacOS
Windows

npm Packages

npm i @taqueria/plugin-archetype@0.22.2-1530.bfd922af --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-contract-types@0.22.2-1530.bfd922af --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-core@0.22.2-1530.bfd922af --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-flextesa@0.22.2-1530.bfd922af --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-ipfs-pinata@0.22.2-1530.bfd922af --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-jest@0.22.2-1530.bfd922af --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-ligo@0.22.2-1530.bfd922af --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-metadata@0.22.2-1530.bfd922af --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-smartpy@0.22.2-1530.bfd922af --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-taquito@0.22.2-1530.bfd922af --registry https://npm.ecadinfra.com
npm i @taqueria/plugin-tezos-client@0.22.2-1530.bfd922af --registry https://npm.ecadinfra.com
npm i @taqueria/protocol@0.22.2-1530.bfd922af --registry https://npm.ecadinfra.com
npm i @taqueria/node-sdk@0.22.2-1530.bfd922af --registry https://npm.ecadinfra.com
npm i @taqueria/state@0.22.2-1530.bfd922af --registry https://npm.ecadinfra.com
npm i @taqueria/toolkit@0.22.2-1530.bfd922af --registry https://npm.ecadinfra.com
npm i @0.22.2-1530.bfd922af --registry https://npm.ecadinfra.com
VSCode Extension VSIX

taqueria-vscode-improvements-to-build-and-test-ubuntu-latest

danielelisi
danielelisi reviewed Nov 21, 2022
View reviewed changes
bin/build-all.sh
npm install
npm run bootstrap
echo "** Checking Dependencies"
docker ps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker is used at the very last steps of build-all. So if the engine is not running, the user will be informed only after building everything and failing at the last step. With this change, they will be notified right after the run command build-all.

danielelisi
danielelisi reviewed Nov 21, 2022
View reviewed changes
taqueria-flextesa-manager/package.json Outdated
@@ -6,7 +6,7 @@
"main": "index.js",
"scripts": {
"build-package": "npx tsc -noEmit && npx esbuild --platform=node --bundle index.ts --outdir=.",
"build-docker": "TAQ_VERSION=`taq --version` BUILD=`taq --build`; docker build . -t \"ghcr.io/ecadlabs/taqueria-flextesa:${TAQ_VERSION}-${BUILD}\"",
"build-docker": "TAQ_VERSION=`../taq --version` BUILD=`../taq --build`; docker build . -t \"ghcr.io/ecadlabs/taqueria-flextesa:${TAQ_VERSION}-${BUILD}\"",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we source these from git instead taq ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can. I'm not sure which one is better. Or even if there is a real difference for us.
What's your opinion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, I felt that this was the smaller change that fixed the problem we already have, so I went with this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can use git it'd be more desirable

@github-actions
Copy link
Contributor

The docker image has been published and is avaiable here. Look for the image with the tag pr-1530-5cc0990. The image is available for the following platforms: linux/amd64 and linux/arm64/v8.

@github-actions
Copy link
Contributor

The docker image has been published and is avaiable here. Look for the image with the tag pr-1530-6f8f8f1. The image is available for the following platforms: linux/amd64 and linux/arm64/v8.

@github-actions
Copy link
Contributor

The docker image has been published and is avaiable here. Look for the image with the tag pr-1530-3f48427. The image is available for the following platforms: linux/amd64 and linux/arm64/v8.

@ac10n ac10n force-pushed the improvements-to-build-and-test branch from a7c8e26 to 8269ddd Compare November 22, 2022 13:10
@github-actions
Copy link
Contributor

The docker image has been published and is avaiable here. Look for the image with the tag pr-1530-3ad3457. The image is available for the following platforms: linux/amd64 and linux/arm64/v8.

@github-actions
Copy link
Contributor

The docker image has been published and is avaiable here. Look for the image with the tag pr-1530-3a13ead. The image is available for the following platforms: linux/amd64 and linux/arm64/v8.

@ac10n ac10n force-pushed the improvements-to-build-and-test branch from bf6cc67 to ab5cd92 Compare November 22, 2022 21:59
@github-actions
Copy link
Contributor

The docker image has been published and is avaiable here. Look for the image with the tag pr-1530-48a853b. The image is available for the following platforms: linux/amd64 and linux/arm64/v8.

@ac10n ac10n force-pushed the improvements-to-build-and-test branch from ab5cd92 to a6c9205 Compare November 24, 2022 08:10
@github-actions
Copy link
Contributor

The docker image has been published and is avaiable here. Look for the image with the tag pr-1530-496ded0. The image is available for the following platforms: linux/amd64 and linux/arm64/v8.

@github-actions
Copy link
Contributor

The docker image has been published and is avaiable here. Look for the image with the tag pr-1530-20a4b45. The image is available for the following platforms: linux/amd64 and linux/arm64/v8.

@github-actions
Copy link
Contributor

The docker image has been published and is avaiable here. Look for the image with the tag pr-1530-7f6f922. The image is available for the following platforms: linux/amd64 and linux/arm64/v8.

@ac10n ac10n marked this pull request as ready for review November 24, 2022 10:43
@ac10n ac10n requested a review from a team November 24, 2022 10:43
@github-actions
Copy link
Contributor

The docker image has been published and is avaiable here. Look for the image with the tag pr-1530-c28ccdb. The image is available for the following platforms: linux/amd64 and linux/arm64/v8.

@ac10n ac10n force-pushed the improvements-to-build-and-test branch from 9d39fa4 to ad97174 Compare November 24, 2022 10:55
@github-actions
Copy link
Contributor

The docker image has been published and is avaiable here. Look for the image with the tag pr-1530-f6711fb. The image is available for the following platforms: linux/amd64 and linux/arm64/v8.

@github-actions
Copy link
Contributor

The docker image has been published and is avaiable here. Look for the image with the tag pr-1530-a779e4f. The image is available for the following platforms: linux/amd64 and linux/arm64/v8.

jchenche
jchenche approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@jchenche jchenche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just left one comment but if it's not easy to do, it's no problem.

taqueria-flextesa-manager/package.json Outdated
@@ -6,7 +6,7 @@
"main": "index.js",
"scripts": {
"build-package": "npx tsc -noEmit && npx esbuild --platform=node --bundle index.ts --outdir=.",
"build-docker": "TAQ_VERSION=`taq --version` BUILD=`taq --build`; docker build . -t \"ghcr.io/ecadlabs/taqueria-flextesa:${TAQ_VERSION}-${BUILD}\"",
"build-docker": "TAQ_VERSION=`../taq --version` BUILD=`../taq --build`; docker build . -t \"ghcr.io/ecadlabs/taqueria-flextesa:${TAQ_VERSION}-${BUILD}\"",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can use git it'd be more desirable

@github-actions
Copy link
Contributor

The docker image has been published and is avaiable here. Look for the image with the tag pr-1530-f76d85d. The image is available for the following platforms: linux/amd64 and linux/arm64/v8.

@ac10n ac10n merged commit 49bf148 into main Nov 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2022
@ac10n ac10n deleted the improvements-to-build-and-test branch December 8, 2022 00:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danielelisi danielelisi danielelisi left review comments

@jchenche jchenche jchenche approved these changes

@hu3man hu3man hu3man approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ac10n @danielelisi @jchenche @hu3man