Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(docker): Add workflow to build and publish images #146

Merged
merged 18 commits into from
Jan 27, 2022

Conversation

GImbrailo
Copy link
Contributor

@GImbrailo GImbrailo commented Jan 27, 2022

The PR sets up the docker build and publish workflow for a list of plugins in a matrix. This is only needed for the flextesa plugin currently

Test Plan
Please see the Release section of the repo for listed packages

image

image

Please see this PR for the docker comments

Ref #38

@GImbrailo GImbrailo self-assigned this Jan 27, 2022
@github-actions
Copy link
Contributor

Git Commit Artifacts
e95cdc8 Linux
MacOS
Windows
npm package installation instructions
npm install @ecadlabs/plugin-ligo@0.0.1-146-e95cdc8
npm install @ecadlabs/plugin-smartpy@0.0.1-146-e95cdc8
npm install @ecadlabs/plugin-taquito@0.0.1-146-e95cdc8
npm install @ecadlabs/node-sdk@0.0.1-146-e95cdc8

@github-actions
Copy link
Contributor

Git Commit Artifacts
5549a66 Linux
MacOS
Windows
npm package installation instructions
npm install @ecadlabs/plugin-ligo@0.0.1-146-5549a66
npm install @ecadlabs/plugin-smartpy@0.0.1-146-5549a66
npm install @ecadlabs/plugin-taquito@0.0.1-146-5549a66
npm install @ecadlabs/node-sdk@0.0.1-146-5549a66

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 27, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 648d146
Status: ✅  Deploy successful!
Preview URL: https://3ec067a7.taqueria.pages.dev

View logs

@github-actions
Copy link
Contributor

Git Commit Artifacts
544411e Linux
MacOS
Windows
npm package installation instructions
npm install @ecadlabs/plugin-ligo@0.0.1-146-544411e
npm install @ecadlabs/plugin-smartpy@0.0.1-146-544411e
npm install @ecadlabs/plugin-taquito@0.0.1-146-544411e
npm install @ecadlabs/node-sdk@0.0.1-146-544411e

@github-actions
Copy link
Contributor

The latest docker name:tag for this PR is ****** 🐳 🚢

@github-actions
Copy link
Contributor

The latest docker name:tag for this PR is ghcr.io/ecadlabs/taqueria-plugin-flextesa:pr-146-d161ec1 🐳 🚢

@github-actions
Copy link
Contributor

The latest docker name:tag for this PR is ghcr.io/ecadlabs/taqueria-plugin-flextesa:pr-146-80fe548 🐳 🚢

@github-actions
Copy link
Contributor

Git Commit Artifacts
0fe548c Linux
MacOS
Windows
npm package installation instructions
npm install @ecadlabs/plugin-ligo@0.0.1-146-0fe548c
npm install @ecadlabs/plugin-smartpy@0.0.1-146-0fe548c
npm install @ecadlabs/plugin-taquito@0.0.1-146-0fe548c
npm install @ecadlabs/node-sdk@0.0.1-146-0fe548c

@GImbrailo GImbrailo marked this pull request as ready for review January 27, 2022 01:54
@GImbrailo GImbrailo requested review from jevonearth, mweichert and a team as code owners January 27, 2022 01:54
@GImbrailo GImbrailo requested a review from danielelisi January 27, 2022 01:54
Copy link
Contributor

@danielelisi danielelisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this pipeline detect when to push a semver tag? From what I read seems like anyone could push a semver tags from a pr?

@github-actions
Copy link
Contributor

The latest docker name:tag for this PR is ghcr.io/ecadlabs/taqueria-plugin-flextesa:pr-146-4ddbf57 🐳 🚢

@github-actions
Copy link
Contributor

Git Commit Artifacts
ddbf57e Linux
MacOS
Windows
npm package installation instructions
npm install @ecadlabs/plugin-ligo@0.0.1-146-ddbf57e
npm install @ecadlabs/plugin-smartpy@0.0.1-146-ddbf57e
npm install @ecadlabs/plugin-taquito@0.0.1-146-ddbf57e
npm install @ecadlabs/node-sdk@0.0.1-146-ddbf57e

@github-actions
Copy link
Contributor

The latest docker name:tag for this PR is ghcr.io/ecadlabs/taqueria-plugin-flextesa:pr-146-446add1 🐳 🚢

@github-actions
Copy link
Contributor

Git Commit Artifacts
46add15 Linux
MacOS
Windows
npm package installation instructions
npm install @ecadlabs/plugin-ligo@0.0.1-146-46add15
npm install @ecadlabs/plugin-smartpy@0.0.1-146-46add15
npm install @ecadlabs/plugin-taquito@0.0.1-146-46add15
npm install @ecadlabs/node-sdk@0.0.1-146-46add15

@GImbrailo
Copy link
Contributor Author

How does this pipeline detect when to push a semver tag? From what I read seems like anyone could push a semver tags from a pr?

@danielelisi from my understanding this is done in the Exctract metadata job. The tags are set and defined on lines 45 -49 of the workflow

          tags: |
            type=ref,event=branch
            type=ref,event=pr,suffix=-{{sha}}
            type=semver,pattern={{version}}
            type=semver,pattern={{major}}.{{minor}}

The documentation on the docker/metadata-action repo provide more information on the various types and how to configure them

@GImbrailo GImbrailo requested a review from danielelisi January 27, 2022 17:39
@GImbrailo
Copy link
Contributor Author

GImbrailo commented Jan 27, 2022

@danielelisi based on the comments in the SRE standup, I am going to make some more changes here

  • This docker workflow is only for flextesa and therefore should be named accordingly.
  • The workflow does not need to be in a matrix
  • The docker image name should change for taqueria-plugin-flextesa to taqueria-flextesa

@GImbrailo GImbrailo marked this pull request as draft January 27, 2022 18:20
@github-actions
Copy link
Contributor

The latest docker name:tag for this PR is ghcr.io/ecadlabs/taqueria-flextesa:pr-146-10bf09c 🐳 🚢

@github-actions
Copy link
Contributor

Git Commit Artifacts
0bf09c2 Linux
MacOS
Windows
npm package installation instructions
npm install @ecadlabs/plugin-ligo@0.0.1-146-0bf09c2
npm install @ecadlabs/plugin-smartpy@0.0.1-146-0bf09c2
npm install @ecadlabs/plugin-taquito@0.0.1-146-0bf09c2
npm install @ecadlabs/node-sdk@0.0.1-146-0bf09c2

@github-actions
Copy link
Contributor

The latest docker name:tag for this PR is ghcr.io/ecadlabs/taqueria-flextesa:pr-146-eeffa35 🐳 🚢

@github-actions
Copy link
Contributor

Git Commit Artifacts
effa35f Linux
MacOS
Windows
npm package installation instructions
npm install @ecadlabs/plugin-ligo@0.0.1-146-effa35f
npm install @ecadlabs/plugin-smartpy@0.0.1-146-effa35f
npm install @ecadlabs/plugin-taquito@0.0.1-146-effa35f
npm install @ecadlabs/node-sdk@0.0.1-146-effa35f

@GImbrailo GImbrailo marked this pull request as ready for review January 27, 2022 19:33
@github-actions
Copy link
Contributor

The latest docker name:tag for this PR is ghcr.io/ecadlabs/taqueria-flextesa:pr-146-ced9c9e 🐳 🚢

@github-actions
Copy link
Contributor

Git Commit Artifacts
ed9c9ee Linux
MacOS
Windows
npm package installation instructions
npm install @taqueria/plugin-ligo@0.0.1-146-ed9c9ee
npm install @taqueria/plugin-smartpy@0.0.1-146-ed9c9ee
npm install @taqueria/plugin-taquito@0.0.1-146-ed9c9ee
npm install @taqueria/node-sdk@0.0.1-146-ed9c9ee

@GImbrailo GImbrailo merged commit 32402bd into main Jan 27, 2022
@hu3man hu3man deleted the 38-flextesa-docker-build-and-publish branch August 5, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants