Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish VSCode Extension to the Marketplace #142

Merged
merged 2 commits into from
Jan 26, 2022
Merged

Publish VSCode Extension to the Marketplace #142

merged 2 commits into from
Jan 26, 2022

Conversation

danielelisi
Copy link
Contributor

@danielelisi danielelisi commented Jan 26, 2022 •
edited
Loading

Closes #97

PR #132 was merged early without going through code review so please feel free to review the entire pipeline.

Description

This PR and #132 create a pipeline for linting, testing, building, and publishing the VS Code Extension to the VS Code Marketplace.

Now that Taqueria repo is public I'm running the lint and test job on Windows and MacOS as well.

Test Plan

The pipeline succeed and the extension is successfully published to the marketplace.

VS Code Marketplace Link: https://marketplace.visualstudio.com/items?itemName=ecadlabs.taqueria

Screenshot from 2022-01-26 12-25-06

@danielelisi danielelisi requested a review from a team as a code owner January 26, 2022 19:42
@danielelisi danielelisi self-assigned this Jan 26, 2022
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 26, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5865ce0
Status: ✅  Deploy successful!
Preview URL: https://3176c82b.taqueria.pages.dev

View logs

@danielelisi danielelisi changed the title Publish VSCode Extension to the Marketplace Draft: Publish VSCode Extension to the Marketplace Jan 26, 2022
@danielelisi danielelisi marked this pull request as draft January 26, 2022 19:44
@danielelisi danielelisi changed the title Draft: Publish VSCode Extension to the Marketplace Publish VSCode Extension to the Marketplace Jan 26, 2022
@github-actions
Copy link
Contributor

Artifacts
Linux
Windows
MacOS

@github-actions
Copy link
Contributor

npm package installation instructions
npm install @ecadlabs/plugin-ligo@0.0.1 --registry=https://npm.pkg.github.com/
npm install @ecadlabs/plugin-smartpy@0.0.1 --registry=https://npm.pkg.github.com/
npm install @ecadlabs/plugin-taquito@0.0.1 --registry=https://npm.pkg.github.com/
npm install @ecadlabs/node-sdk@0.0.1 --registry=https://npm.pkg.github.com/

@github-actions
Copy link
Contributor

Artifacts
Linux
Windows
MacOS

@github-actions
Copy link
Contributor

npm package installation instructions
npm install @ecadlabs/plugin-ligo@0.0.1 --registry=https://npm.pkg.github.com/
npm install @ecadlabs/plugin-smartpy@0.0.1 --registry=https://npm.pkg.github.com/
npm install @ecadlabs/plugin-taquito@0.0.1 --registry=https://npm.pkg.github.com/
npm install @ecadlabs/node-sdk@0.0.1 --registry=https://npm.pkg.github.com/

@github-actions
Copy link
Contributor

Artifacts
Linux
Windows
MacOS

@github-actions
Copy link
Contributor

npm package installation instructions
npm install @ecadlabs/plugin-ligo@0.0.1 --registry=https://npm.pkg.github.com/
npm install @ecadlabs/plugin-smartpy@0.0.1 --registry=https://npm.pkg.github.com/
npm install @ecadlabs/plugin-taquito@0.0.1 --registry=https://npm.pkg.github.com/
npm install @ecadlabs/node-sdk@0.0.1 --registry=https://npm.pkg.github.com/

@github-actions
Copy link
Contributor

Artifacts
Linux
Windows
MacOS

@github-actions
Copy link
Contributor

npm package installation instructions
npm install @ecadlabs/plugin-ligo@0.0.1 --registry=https://npm.pkg.github.com/
npm install @ecadlabs/plugin-smartpy@0.0.1 --registry=https://npm.pkg.github.com/
npm install @ecadlabs/plugin-taquito@0.0.1 --registry=https://npm.pkg.github.com/
npm install @ecadlabs/node-sdk@0.0.1 --registry=https://npm.pkg.github.com/

@github-actions
Copy link
Contributor

Artifacts
Linux
Windows
MacOS

@github-actions
Copy link
Contributor

npm package installation instructions
npm install @ecadlabs/plugin-ligo@0.0.1 --registry=https://npm.pkg.github.com/
npm install @ecadlabs/plugin-smartpy@0.0.1 --registry=https://npm.pkg.github.com/
npm install @ecadlabs/plugin-taquito@0.0.1 --registry=https://npm.pkg.github.com/
npm install @ecadlabs/node-sdk@0.0.1 --registry=https://npm.pkg.github.com/

@danielelisi danielelisi force-pushed the fix_vscode_extension_publishing branch from d8d8b73 to 5865ce0 Compare January 26, 2022 20:29
@danielelisi danielelisi marked this pull request as ready for review January 26, 2022 20:29
@github-actions
Copy link
Contributor

Artifacts
Linux
Windows
MacOS

@github-actions
Copy link
Contributor

npm package installation instructions
npm install @ecadlabs/plugin-ligo@0.0.1 --registry=https://npm.pkg.github.com/
npm install @ecadlabs/plugin-smartpy@0.0.1 --registry=https://npm.pkg.github.com/
npm install @ecadlabs/plugin-taquito@0.0.1 --registry=https://npm.pkg.github.com/
npm install @ecadlabs/node-sdk@0.0.1 --registry=https://npm.pkg.github.com/

GImbrailo
GImbrailo approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@GImbrailo GImbrailo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielelisi This LGTM.

@danielelisi danielelisi force-pushed the fix_vscode_extension_publishing branch from 5865ce0 to de91d1c Compare January 26, 2022 20:38
@github-actions
Copy link
Contributor

Artifacts
Linux
Windows
MacOS

@github-actions
Copy link
Contributor

npm package installation instructions
npm install @ecadlabs/plugin-ligo@0.0.1 --registry=https://npm.pkg.github.com/
npm install @ecadlabs/plugin-smartpy@0.0.1 --registry=https://npm.pkg.github.com/
npm install @ecadlabs/plugin-taquito@0.0.1 --registry=https://npm.pkg.github.com/
npm install @ecadlabs/node-sdk@0.0.1 --registry=https://npm.pkg.github.com/

@danielelisi
Copy link
Contributor Author

I've added a condition to this pipeline to trigger only if files inside taqueria-vscode-extension are changed

on:
  pull_request:
    branches:
      - main
    paths:
      - 'taqueria-vscode-extension/**'

@danielelisi danielelisi merged commit 92944eb into main Jan 26, 2022
@danielelisi danielelisi deleted the fix_vscode_extension_publishing branch January 26, 2022 20:41
GImbrailo pushed a commit that referenced this pull request Jan 26, 2022
@danielelisi @GImbrailo
Publish VSCode Extension to the Marketplace (#142)
346f661 
* Fix publishing job for VSCode Extension

* Trigger workflow only if vscode extension code is changed
GImbrailo added a commit that referenced this pull request Jan 27, 2022
@GImbrailo @danielelisi
@carte7000 @jevonearth
Release publish NPM packages (#126)
75a019a 
* chore: renamed build-and-test to build-binaries

* chore: add npm build packages

* chore: added npm scripts and publish jobs

* chore: fixed duplicate job ids

* chore: moved update package.json to npm script

* chore: added plugin list outputs

* chore: added plugin variable to update commad

* chore: added node actions to release

* chore: added checkout to release

* chore: moved checkout and changed conditions for publish

* chore: changed suffix output

* chore: added --registry to npm publish

* chore: added node token

* chore: fixed npm publish command

* chore: seperate npm publish from release

* chore: seperate npm publish from release

* chore: removed teztnets

* chore: removed flextesa

* chore: removed redundant build job

* chore: try npm version

* chore: try npm version

* chore: try npm version

* chore: try npm version

* chore: added access to public

* chore: npm publish jobs

* chore: added global env variables

* chore: changed scope to taqueria

* chore: changed tag for PR

* chore: changed tag for PR

* chore: updated website packages

* chore: changed binary name to taq

* chore: removed custom npm scripts

* chore: removed windows and mac binaries until merge

* chore: try merge comment jobs in one

* chore: try merge comment jobs in one

* chore: cleanup environment variables

* chore: change npm version

* chore: change npm version

* chore: GITHUB_SHA env expression

* chore: short sha in javascript

* chore: short sha in javascript

* chore: fix comment tag

* chore: add line break

* chore: add line break

* Automatically run npm install before running npm run build

* Update .gitignore for vscode-extension

* Update .gitignore

* Taqueria vscode initial commit

* Initial init command

* Rebase branch on latest changes from main

* VSCode Extension pipeline for testing, building, and publishing

* fix string interpolation

* set default working-directory

* Fix typo on output

* remove working-dir default

* add file extension

* chore: update README warning

* Publish VSCode Extension to the Marketplace (#142)

* Fix publishing job for VSCode Extension

* Trigger workflow only if vscode extension code is changed

* chore: publish next and latest if release is published

* chore: fixed next check

* chore: fixed package-lock.json for protocol

* chore: using scope env variable

Co-authored-by: Michael Weichert <mweichert.com>
Co-authored-by: Daniele Lisi <22307776+danielelisi@users.noreply.github.com>
Co-authored-by: Simon Boissonneault-Robert <simrob7000@gmail.com>
Co-authored-by: Jev Björsell <jev@ecadlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GImbrailo GImbrailo GImbrailo approved these changes

@jevonearth jevonearth Awaiting requested review from jevonearth

@mweichert mweichert Awaiting requested review from mweichert

Assignees

@danielelisi danielelisi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TASK: Automated VS Code Extension Publishing
2 participants
@danielelisi @GImbrailo