Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚧 Dev ➾ Clean up e2e test config.json to match format of newly initialized projects #1376

Closed
8 of 9 tasks
alexzbusko opened this issue Oct 17, 2022 · 0 comments
Closed
8 of 9 tasks

🚧 Dev ➾ Clean up e2e test config.json to match format of newly initialized projects #1376

alexzbusko opened this issue Oct 17, 2022 · 0 comments
Assignees
@alexzbusko
Labels
dev-task Tasks for the Taqueria Dev Board

Comments

@alexzbusko
Copy link
Contributor

alexzbusko commented Oct 17, 2022 •
edited by hu3man
Loading

🔗 Epic|Feature Link

No response

🚥 Definition of Done

  • 🎯 Planning and Design
  • 🏎️ Dev Implementation (PR merged)
  • ✍️ Release Notes Added
  • 🏆 Product Acceptance

✅ To Do

  • Update all config.json files to have the structure of a newly initialized project (including faucet information)
  • Remove all config.json files that are not being used within test spec files
  • Update port numbers for local sandboxes to match current increment structure with unused config files removed

⚖️ Acceptance Criteria

✨ Functional:

  • All tests pass with new structure
  • [ ]

🔭 Scope

🙅‍♂️ Out of Scope:

  • ...

🧰 Work Description

We should update the config.json files we use for the e2e tests to be more in-line with the structure that a new project has. We also have some config.json files that are not used with our current e2e tests which should be removed. We have a 10-increment port number scheme which we use to prevent port collisions when starting sandboxes in the pipeline

🦄 Sizing

1

Code of Conduct

  • I agree to follow this project's Code of Conduct
@alexzbusko alexzbusko added the dev-task Tasks for the Taqueria Dev Board label Oct 17, 2022
@alexzbusko alexzbusko moved this to 📫 Inbox in 📬 Inbox and Triage Oct 17, 2022
@hu3man hu3man closed this as completed Nov 14, 2022
hu3man added a commit that referenced this issue Nov 23, 2022
@alexzbusko @hu3man
Fixes #1376, e2e tests config cleanup (#1540)
86359f5 
* removed unused config files and skipped tests depending on them

* removed skipped tests or refactored them if still valid. Removed a bunch of config.json files as well

* removed single thread for testing

* added logging for transfer test

* logging for account listing

* removing deleted files which I accidentally merged back in during update from main

* updated to use modern config.json files

* updated bad URL tests

* updated network name test

* WIP for storage string test json

* completed modernizing storage string json

* low tez test refactor

* pinning node version in main.yml and updated to modern taquito test json

* slight node version bump

* trying to update to v18 for node

* trying to rebuild before running all other commands

* added git clean to setup script

* more testing for CI

* removed CI stuff

* checking NPM registry for CI job

* removed logging

* added docker build back to caching

* updated ports in each file to be sequential

* updated tests for config changes

* making CI use the 20000 port for taquito flextesa tests

* updated help for correct port number

* logging for CI debugging

* added logging to see what ports are in use on the machine when the test runs

* more verbose logging for docker

* adding more logging for docker containers

* more logging

* adding wait for containers to start up

* more logging for scaffold flextesa image

* added logging to see what is on port 20000

* seeing all ports

* removed chunking from tests

* removed lsof call in test

* updated scaffold sandbox to have scaffold in name to help with identification

* updated test with param to actually test something

* logging for images in new test

* updated util method to get all container IDs

* updated test to use unique sandbox name

* removed long name

* removed only from test

* logging for scaffold tests

* added logging for setup

* upped the timeout time for scaffold tests

* added ports to taquito flextesa to prevent collisions

* putting chunks back in

* mac mini update, I undo'd too far

* updated env var in test

* removing final check to see if container stopped since it can give a false fail in CI

* moving away from local to local-tf for uniqueness checking in tests

* made sandbox name into localTF for taquito-flextesa

* upped test timeout to 10 minutes

* removing logging for testing

* put single worker back in

* going back to parallel workers

* removed unused variable

* removing update to the timeout limit

* logging for taquito flextesa tests

* added max workers=2

* putting max workers back to 1

* Refactored scaffold task to resolve memory leaks. However, there are still some present

* Committing work thus far

* Fixed problem with memory leaks for the scaffold task

* updated test command to not use detect commands and not use CI flag

* added wait for stopping flextesa container

* logging for CI

* upped timeout and making tests not verbose

* added waiting for flextesa sandbox to finish booting up

* removing all console.log messages in tests due to popular demand https://ecadlabs.slack.com/archives/C021J32T05B/p1669155878414139

* upped the test timeout

* removing bad assertiong that has no point

* cleaning up unused variable

* Fixed problem with E2E tests not running correctly

Co-authored-by: Alexander Zbusko <alexander.zbusko@gmail.com>
Co-authored-by: Houston <32914364+hu3man@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexzbusko alexzbusko

Labels
dev-task Tasks for the Taqueria Dev Board
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexzbusko @hu3man