Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sporadic NoMatches error reported from Header on app shutdown #4817

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix sporadic NoMatches error reported from Header on app shutdown #4817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/textual/widgets/_header.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from rich.text import Text

from ..app import RenderResult
from ..css.query import NoMatches
from ..dom import NoScreen
from ..events import Click, Mount
from ..reactive import Reactive
Expand Down Expand Up @@ -216,13 +217,13 @@ def _on_mount(self, _: Mount) -> None:
async def set_title() -> None:
try:
self.query_one(HeaderTitle).text = self.screen_title
except NoScreen:
except (NoScreen, NoMatches):
pass

async def set_sub_title() -> None:
try:
self.query_one(HeaderTitle).sub_text = self.screen_sub_title
except NoScreen:
except (NoScreen, NoMatches):
pass

self.watch(self.app, "title", set_title)
Expand Down