Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4722: DataTable add_rows gives incorrect error message #4742

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

merriam
Copy link
Contributor

@merriam merriam commented Jul 15, 2024

Please review the following checklist.

  • [n/a] Docstrings on all new or modified functions / classes
  • [n/a] Updated documentation
  • [n/a ] Updated CHANGELOG.md (where appropriate)

Providing too many values to add_rows gave an Attribute Error: 'NoneType' object has no attribute 'key'.
It now gives ValueError: More values provided than there are columns..

Fix and test case provided.

Copy link
Member

@darrenburns darrenburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement - thanks!

@darrenburns darrenburns merged commit b50e697 into Textualize:main Jul 15, 2024
18 of 19 checks passed
@merriam merriam deleted the DataTableErrorMessage branch July 29, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants