Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): disabled tab not activated by clicking underline #4702

Conversation

TomJGooding
Copy link
Contributor

@TomJGooding TomJGooding commented Jul 4, 2024

Fixes #4701.

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@merriam
Copy link
Contributor

merriam commented Jul 8, 2024

lgtm

Fix is one line. Verified test fails without the fix and passes with it.

Copy link
Member

@darrenburns darrenburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@darrenburns darrenburns merged commit fad03c8 into Textualize:main Jul 11, 2024
12 of 13 checks passed
@mayermakes
Copy link

Awesome!

@TomJGooding TomJGooding deleted the fix-tabs-disabled-tab-not-activated-by-clicking-underline branch July 11, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled TabPane can still be Accessed/selected via the underline bar
4 participants