allow empty css variables #2984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looking good!
I was looking at the if: ... elif: ... elif: ... and I see we are now doing variables.setdefault in pretty much all of the branches that look interesting.
Is it possible that we can call setdefault earlier and then use regular dictionary access where we are currently using setdefault + append?
I'm not sure we can & if we can, not sure it'll help.
But I'd like you to give it some thought, if possible.
Thanks!
rodrigogiraoserrao
approved these changes
Jul 22, 2023
zormit
force-pushed
the
allow-empty-css-variables
branch
from
733fbb9 to
7770f8d
Compare
rodrigogiraoserrao
approved these changes
Jul 22, 2023
|
@willmcgugan this is ready for you to take a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1849
Please review the following checklist.
Co-authored-by: @eliasdorneles