Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CancelledError #2895

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Fix CancelledError #2895

merged 3 commits into from
Jul 6, 2023

Conversation

willmcgugan
Copy link
Collaborator

Fixes #2854

In Python3.7 CancelledError extends Exception, in 3.8 and above it does not.

@rodrigogiraoserrao rodrigogiraoserrao mentioned this pull request Jul 6, 2023
Closed
@willmcgugan willmcgugan merged commit c2f0771 into main Jul 6, 2023
@willmcgugan willmcgugan deleted the fix-ce branch July 6, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigogiraoserrao rodrigogiraoserrao rodrigogiraoserrao approved these changes

@davep davep Awaiting requested review from davep

@darrenburns darrenburns Awaiting requested review from darrenburns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CancelledError when doing a self.remove from a timer (in Python 3.7 but not Python 3.11)
2 participants
@willmcgugan @rodrigogiraoserrao